fix: optionally processing all forms opportunity #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
added 7 commits
November 19, 2025 14:30
vdua
approved these changes
Nov 19, 2025
vdua
reviewed
Nov 19, 2025
| if (opptyOptions !== OPPTY_OPTIONS_ALL) { | ||
| // Apply filtering logic: deduplicate, filter INVALIDATED, and limit to top opportunities | ||
| // eslint-disable-next-line max-len | ||
| filteredOpportunities = applyOpportunityFilters(filteredOpportunities, opportunities, FORM_OPPORTUNITY_TYPES.LOW_VIEWS, log, OPPORTUNITY_LIMIT); |
There was a problem hiding this comment.
I would log all opportunities length and filtered opportunities length as well.
vdua
approved these changes
Nov 20, 2025
solaris007
pushed a commit
that referenced
this pull request
Nov 20, 2025
# [1.247.0](v1.246.6...v1.247.0) (2025-11-20) ### Bug Fixes * optionally processing all forms opportunity ([#1607](#1607)) ([008f5f5](008f5f5)) * test failures ([#1615](#1615)) ([d898d82](d898d82)) ### Features * [SITES-36639] Spacecat A11y Autofix suggestion grouping ([#1449](#1449)) ([11359ac](11359ac)) * introduce headings audit in preflight ([#1562](#1562)) ([0733a90](0733a90))
Member
|
🎉 This PR is included in version 1.247.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!