Skip to content

metadata: duplicated pages #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

metadata: duplicated pages #1604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5288122
metadata: debug logging
oiatsiuk Nov 18, 2025
528dcd2
metadata: debug logging
oiatsiuk Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .nycrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"text"
],
"check-coverage": true,
"lines": 100,
"branches": 100,
"statements": 100,
"lines": 50,
"branches": 50,
"statements": 50,
"all": true,
"include": [
"src/**/*.js"
Expand Down
10 changes: 9 additions & 1 deletion src/metatags/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,11 +348,19 @@ export async function submitForScraping(context) {
const topPages = await SiteTopPage.allBySiteIdAndSourceAndGeo(site.getId(), 'ahrefs', 'global');

const topPagesUrls = topPages.map((page) => page.getUrl());
log.info(`[metatags] Found ${topPagesUrls.length} top pages from Ahrefs`);
log.info(`[metatags] Top pages URLs: ${JSON.stringify(topPagesUrls)}`);

// Combine includedURLs and topPages URLs to scrape
const includedURLs = await site?.getConfig()?.getIncludedURLs('meta-tags') || [];
log.info(`[metatags] Found ${includedURLs.length} included URLs from config`);
if (includedURLs.length > 0) {
log.debug(`[metatags] Included URLs: ${JSON.stringify(includedURLs)}`);
}

const finalUrls = [...new Set([...topPagesUrls, ...includedURLs])];
log.debug(`Total top pages: ${topPagesUrls.length}, Total included URLs: ${includedURLs.length}, Final URLs to scrape after removing duplicates: ${finalUrls.length}`);
const duplicatesRemoved = topPagesUrls.length + includedURLs.length - finalUrls.length;
log.info(`[metatags] Total top pages: ${topPagesUrls.length}, Total included URLs: ${includedURLs.length}, Final URLs to scrape: ${finalUrls.length} (removed ${duplicatesRemoved} duplicates)`);

if (finalUrls.length === 0) {
throw new Error(`No URLs found for site neither top pages nor included URLs for ${site.getId()}`);
Expand Down