feat: adding empty suggestion for forms opportunity #1595
Conversation
barshat7
force-pushed
the
forms-suggestion-object
branch
from
3ba4f6c to
abd06c8
Compare
|
This PR will trigger a minor release when merged. |
| * @param newSuggestions | ||
| * @returns {Promise<void>} | ||
| */ | ||
| async function addSuggestions( |
There was a problem hiding this comment.
move this to common utils for all three oppties.
| const wrappedGuidance = { recommendations: guidance }; | ||
| opportunity.setGuidance(wrappedGuidance); | ||
| opportunity.setUpdatedBy('system'); | ||
| await addSuggestions(opportunity, suggestions); |
There was a problem hiding this comment.
opportunity gets created before this in low-conversion-handler.js with default guidance, shouldn't this be added there.
Scenario where mystique fails to send response back and oppty remains in backoffice without suggestion.
There was a problem hiding this comment.
this is the handler where it receives the guidance generated by Mystique. Suggestions are also generated by Mystique which we will update it here once we have implemented it there.
e.g
There was a problem hiding this comment.
What happens if Mystique doesn’t provide guidance? We will loose on oppties to show on ASO UI as it'll not have suggestion object or am i missing something here.
There was a problem hiding this comment.
If there are no suggestions, or in pending_validation state they will not be visible in ASO UI. That is the contract as of now.
| opportunityId: opportunity.opportunityId, | ||
| type: 'CONTENT_UPDATE', | ||
| rank: 1, | ||
| status: 'NEW', |
There was a problem hiding this comment.
shouldn't this be PENDING_VALIDATION?
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!