Skip to content

LLMO-1023 (#1519) #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

LLMO-1023 (#1519) #1520

wants to merge 2 commits into from
+2 −1

Conversation

@HollywoodTonight
Copy link

@HollywoodTonight HollywoodTonight commented Nov 6, 2025

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes
  • If data sources for any opportunity has been updated/added, please update the
    wiki for same opportunity.

Related Issues

Thanks for contributing!

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes
  • If data sources for any opportunity has been updated/added, please update the wiki for same opportunity.

Related Issues

Thanks for contributing!

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

This PR will trigger a minor release when merged.

@HollywoodTonight HollywoodTonight mentioned this pull request Nov 19, 2025
Closed
3 tasks
iuliag
iuliag approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@iuliag iuliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the shared dependency version once released.

@HollywoodTonight HollywoodTonight mentioned this pull request Nov 20, 2025
Merged
HollywoodTonight added a commit to adobe/spacecat-shared that referenced this pull request Nov 20, 2025
@HollywoodTonight
feat: release for trace ID propagation (PR #1097) (#1152)
c1d878e 
This PR triggers the semantic-release for the trace ID propagation
feature that was merged in #1097 but didn't get released due to
incorrect commit message format.

## Changes
- Empty commit with proper `feat:` prefix to trigger release

## Related
- Implements: #1097
- Needed for: adobe/spacecat-audit-worker#1520

Once merged, this will release:
- `@adobe/[email protected]` (currently 1.75.0)
- `@adobe/[email protected]` (currently 1.18.2)
@HollywoodTonight HollywoodTonight mentioned this pull request Nov 20, 2025
Merged
HollywoodTonight added a commit to adobe/spacecat-shared that referenced this pull request Nov 20, 2025
@HollywoodTonight
feat(utils,http-utils): trigger release for trace ID propagation (#1154)
fb48149 
## Problem

PR #1152 was merged with a proper `feat:` commit message, but
semantic-release did not trigger a release. This happened because:

- **Empty commits are ignored by `semantic-release-monorepo`**
- The monorepo plugin filters commits to only include those that modify
files within each package directory
- Since #1152 was an empty commit with no file changes, it wasn't
associated with any package
- Result: Both `spacecat-shared-utils` and `spacecat-shared-http-utils`
were not released despite having new features from #1097

## Solution

This PR adds documentation updates to both affected packages:
- **`spacecat-shared-utils`**: Added release note for trace ID
propagation
- **`spacecat-shared-http-utils`**: Added release note for trace ID
extraction

The commit includes:
- Proper `feat(utils,http-utils):` prefix following conventional commits
- Actual file modifications in both package directories
- Will be correctly recognized by `semantic-release-monorepo`

## Changes from PR #1097

The original trace ID propagation feature includes:
- Enhanced `logWrapper` to automatically include `traceId` in log
messages
- SQS message trace ID propagation via
`sendMessage()`/`sqsEventAdapter()`
- HTTP header trace ID extraction via `x-trace-id` header
- New `addTraceIdHeader()` utility function

This enables end-to-end distributed tracing across SpaceCat services.

## Expected Releases

Once merged, semantic-release will publish:
- `@adobe/[email protected]` (currently 1.75.0)
- `@adobe/[email protected]` (currently 1.18.2)

## Related

- Implements: #1097
- Supersedes: #1152
- Needed for: adobe/spacecat-audit-worker#1520
solaris007 pushed a commit to adobe/spacecat-shared that referenced this pull request Nov 20, 2025
@semantic-release-bot
chore(release): 1.19.0 [skip ci]
09b714c 
# [@adobe/spacecat-shared-http-utils-v1.19.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-http-utils-v1.18.2...@adobe/spacecat-shared-http-utils-v1.19.0) (2025-11-20)

### Features

* **utils,http-utils:** trigger release for trace ID propagation ([#1154](#1154)) ([fb48149](fb48149)), closes [#1152](#1152) [#1152](#1152) [#1097](#1097) [#1097](#1097) [#1097](#1097) [#1152](#1152) [adobe/spacecat-audit-worker#1520](adobe/spacecat-audit-worker#1520)
solaris007 pushed a commit to adobe/spacecat-shared that referenced this pull request Nov 20, 2025
@semantic-release-bot
chore(release): 1.76.0 [skip ci]
14a9537 
# [@adobe/spacecat-shared-utils-v1.76.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.75.0...@adobe/spacecat-shared-utils-v1.76.0) (2025-11-20)

### Features

* **utils,http-utils:** trigger release for trace ID propagation ([#1154](#1154)) ([fb48149](fb48149)), closes [#1152](#1152) [#1152](#1152) [#1097](#1097) [#1097](#1097) [#1097](#1097) [#1152](#1152) [adobe/spacecat-audit-worker#1520](adobe/spacecat-audit-worker#1520)
renovate bot added a commit that referenced this pull request Nov 20, 2025
@renovate
fix(deps): update adobe fixes (#1622)
287f4b6 
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
|
[@adobe/spacecat-shared-http-utils](https://redirect.github.com/adobe/spacecat-shared)
| [`1.18.2` ->
`1.19.0`](https://renovatebot.com/diffs/npm/@adobe%2fspacecat-shared-http-utils/1.18.2/1.19.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@adobe%2fspacecat-shared-http-utils/1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@adobe%2fspacecat-shared-http-utils/1.18.2/1.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@adobe/spacecat-shared-utils](https://redirect.github.com/adobe/spacecat-shared)
| [`1.75.0` ->
`1.76.0`](https://renovatebot.com/diffs/npm/@adobe%2fspacecat-shared-utils/1.75.0/1.76.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@adobe%2fspacecat-shared-utils/1.76.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@adobe%2fspacecat-shared-utils/1.75.0/1.76.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>adobe/spacecat-shared
(@&#8203;adobe/spacecat-shared-http-utils)</summary>

###
[`v1.19.0`](https://redirect.github.com/adobe/spacecat-shared/releases/tag/%40adobe/spacecat-shared-http-utils-v1.19.0)

[Compare
Source](https://redirect.github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-http-utils-v1.18.2...@adobe/spacecat-shared-http-utils-v1.19.0)

##### Features

- **utils,http-utils:** trigger release for trace ID propagation
([#&#8203;1154](https://redirect.github.com/adobe/spacecat-shared/issues/1154))
([fb48149](https://redirect.github.com/adobe/spacecat-shared/commit/fb481497725e49dab18812b4ba1ba7186e35a8f9)),
closes
[#&#8203;1152](https://redirect.github.com/adobe/spacecat-shared/issues/1152)
[#&#8203;1152](https://redirect.github.com/adobe/spacecat-shared/issues/1152)
[#&#8203;1097](https://redirect.github.com/adobe/spacecat-shared/issues/1097)
[#&#8203;1097](https://redirect.github.com/adobe/spacecat-shared/issues/1097)
[#&#8203;1097](https://redirect.github.com/adobe/spacecat-shared/issues/1097)
[#&#8203;1152](https://redirect.github.com/adobe/spacecat-shared/issues/1152)
[#1520](https://redirect.github.com/adobe/spacecat-audit-worker/issues/1520)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://redirect.github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/adobe/spacecat-audit-worker).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xNi4xIiwidXBkYXRlZEluVmVyIjoiNDIuMTYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@HollywoodTonight HollywoodTonight force-pushed the LLMO-1023-atudoran branch 2 times, most recently from 156138f to af10296 Compare November 20, 2025 14:23
iuliag
iuliag reviewed Nov 20, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iuliag iuliag iuliag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HollywoodTonight @iuliag