Skip to content

fix: disable variation edit in high organic low ctr opportunity in ASO UI #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: disable variation edit in high organic low ctr opportunity in ASO UI #1518

wants to merge 2 commits into from

Conversation

@rpapani
Copy link
Contributor

@rpapani rpapani commented Nov 6, 2025 •
edited
Loading

Fixes SKYOPS-121236

As per the discussion disabling the Edit for variations

While we can expose an Edit button for a clone, we lack functionality to regenerate the json patch when the user clicks apply in ASO (the patch is the diff between the original and the suggestion, if one modifies the suggestion then the patch is no longer an exact diff and needs to be recreated. Similar situation if the original changes, but let't ignore that now)
Hence the suggestion to hide the Edit button.

  • removed variationEditPageUrl from the variations sent by Mystique before creating Suggestions

@rpapani rpapani requested review from FentPams and ramboz November 6, 2025 03:45
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

This PR will trigger a patch release when merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramboz ramboz ramboz approved these changes

@FentPams FentPams Awaiting requested review from FentPams

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rpapani @ramboz