-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add daily cadence support to geo-brand-presence refresh #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add daily wrapper handler for geo-brand-presence refresh - Update base refresh handler to read cadence from site config - Register refresh:geo-brand-presence-daily message type - Update detect handler to accept both weekly and daily refresh messages - Enable refresh triggering for daily cadence sites (previously disabled) The refresh handler now automatically detects whether a site uses daily or weekly cadence from site.getConfig().getBrandPresenceCadence() and sends the appropriate message type to Mystique.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one question
|
||
// Priority: context (for wrapper) > site config > default | ||
const brandPresenceCadence = context.brandPresenceCadence | ||
|| site.getConfig()?.getBrandPresenceCadence?.() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this still does not exist, does it?
will it ever exist?
otherwise delete it :)
This PR will trigger a minor release when merged. |
# [1.214.0](v1.213.3...v1.214.0) (2025-10-21) ### Features * add daily cadence support to geo-brand-presence refresh ([#1427](#1427)) ([c424012](c424012))
🎉 This PR is included in version 1.214.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The refresh handler now automatically detects whether a site uses daily or weekly cadence from site.getConfig().getBrandPresenceCadence() and sends the appropriate message type to Mystique.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!