Skip to content

Conversation

AdrienCappelaere
Copy link
Contributor

  • Add daily wrapper handler for geo-brand-presence refresh
  • Update base refresh handler to read cadence from site config
  • Register refresh:geo-brand-presence-daily message type
  • Update detect handler to accept both weekly and daily refresh messages
  • Enable refresh triggering for daily cadence sites (previously disabled)

The refresh handler now automatically detects whether a site uses daily or weekly cadence from site.getConfig().getBrandPresenceCadence() and sends the appropriate message type to Mystique.

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes
  • If data sources for any opportunity has been updated/added, please update the wiki for same opportunity.

Related Issues

Thanks for contributing!

- Add daily wrapper handler for geo-brand-presence refresh
- Update base refresh handler to read cadence from site config
- Register refresh:geo-brand-presence-daily message type
- Update detect handler to accept both weekly and daily refresh messages
- Enable refresh triggering for daily cadence sites (previously disabled)

The refresh handler now automatically detects whether a site uses daily or
weekly cadence from site.getConfig().getBrandPresenceCadence() and sends
the appropriate message type to Mystique.
Copy link
Member

@davidaurelio davidaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one question


// Priority: context (for wrapper) > site config > default
const brandPresenceCadence = context.brandPresenceCadence
|| site.getConfig()?.getBrandPresenceCadence?.()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still does not exist, does it?
will it ever exist?
otherwise delete it :)

@github-actions
Copy link

This PR will trigger a minor release when merged.

@davidaurelio davidaurelio merged commit c424012 into main Oct 21, 2025
12 of 14 checks passed
@davidaurelio davidaurelio deleted the feat/geo-brand-presence-daily-refresh branch October 21, 2025 13:15
solaris007 pushed a commit that referenced this pull request Oct 21, 2025
# [1.214.0](v1.213.3...v1.214.0) (2025-10-21)

### Features

* add daily cadence support to geo-brand-presence refresh ([#1427](#1427)) ([c424012](c424012))
@solaris007
Copy link
Member

🎉 This PR is included in version 1.214.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants