-
Notifications
You must be signed in to change notification settings - Fork 13
feat: codefix handler to update suggestions with patch content #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmaurya929
wants to merge
20
commits into
main
Choose a base branch
from
feature/send-autofix-message
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new handler to update accessibility suggestions based on code changes from S3. - Added functionality to read code change reports and update suggestions accordingly. - Included comprehensive tests to ensure correct behavior of the new handler.
…into form-a11y-createsuggestion
…into form-a11y-createsuggestion
vdua
reviewed
Oct 13, 2025
src/forms-opportunities/oppty-handlers/accessibility-handler.js
Outdated
Show resolved
Hide resolved
vdua
reviewed
Oct 14, 2025
…into feature/send-autofix-message
This PR will trigger a minor release when merged. |
vdua
reviewed
Oct 17, 2025
data: { | ||
opportunityId: opportunity.getId(), | ||
suggestionIds: group.suggestionIds, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the forward message has the structure
forward: { queue: ..., data : {}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No forward
field exists currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!