-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Standalone readability opportunities for main ASO UI #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR will trigger a patch release when merged. |
Noticed that you placed the preflight readability check and the readability audit in the same folder. I think they should be stored separately to match the structure used for the other audits and preflight checks—each audit in its own folder, and all preflight handlers within the preflight folder. |
'Use AI-generated suggestions as a starting point for improvements.', | ||
], | ||
}, | ||
tags: ['Content Quality', 'User Experience', 'SEO', 'Traffic Acquisition'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure all of these tags are relevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to ['Engagement', 'Accessibility']
src/index.js
Outdated
'guidance:missing-alt-text': missingAltTextGuidance, | ||
'guidance:readability': readabilityGuidance, | ||
'guidance:readability': unifiedReadabilityGuidance, // unified for both preflight and opportunities | ||
'readability-opportunities': readabilityOpportunities, // for opportunities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the opportunity name should be only readability.
…n the readability opportunities handler
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!