Skip to content

Conversation

@markhicken
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • I have updated the Experience League documentation for the Core Extension
  • All tests pass and I've made any necessary test changes.
  • I have run the extension sandbox successfully.

@jbarchibald
Copy link
Contributor

Looks like this did compile OK, where would i look to find this dist/ folder?

@markhicken
Copy link
Member Author

markhicken commented Aug 19, 2024

Looks like this did compile OK, where would i look to find this dist/ folder?

See https://github.com/actions/upload-artifact?tab=readme-ov-file#outputs

Also, I need to update it to only upload the packaged zip file rather than the whole dist folder.

@markhicken markhicken force-pushed the auto-build-test branch 2 times, most recently from a8b588b to 7298811 Compare August 19, 2024 23:47
@markhicken
Copy link
Member Author

Ok, I have this fixed. It now only uploads the extension package. The key is that it needs to be versioned as part of the PR.
The workflow log now echos a direct link to the artifact.

@brenthosie are you aware of any CI constraints (build limits, storage limits, etc)? We might need to periodically cleanup old builds if they don't do it for us.

@markhicken markhicken changed the title [WIP] Auto build testing Auto build & package Aug 20, 2024
@markhicken markhicken closed this Aug 20, 2024
@markhicken markhicken deleted the auto-build-test branch August 20, 2024 00:05
@markhicken markhicken restored the auto-build-test branch August 20, 2024 00:06
@markhicken
Copy link
Member Author

Ok, apparently renaming the branch closes the PR. :(

Moved to new PR over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants