chore: Refactor codemods #8056
Open
chore: Refactor codemods #8056
+2,359
−2,940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ] | ||
| }, | ||
| ActionGroup: { | ||
| changes: [ |
There was a problem hiding this comment.
just checking, but the declarative approach is going away?
There was a problem hiding this comment.
Yep, I think there were just too many steps to remember to do when adding a codemod. Also with more single component-specific codemods getting added it made less sense.
packages/dev/codemods/src/s1-to-s2/src/codemods/components/ActionGroup/transform.ts
Show resolved
Hide resolved
snowystinger
approved these changes
Apr 16, 2025
| * - Change variant="cta" to variant="accent" | ||
| * - Change variant="overBackground" to variant="primary" staticColor="white" | ||
| * - Change style to fillStyle | ||
| * - Comment out isPending (it has not been implemented yet) |
There was a problem hiding this comment.
we should fix this one https://react-spectrum.adobe.com/s2/index.html?path=/docs/button--docs not in this PR, just tasks we follow up with
Or, I guess it's just deleting the line?
There was a problem hiding this comment.
I can clean this up in a follow-up, and double check that others are updated as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to add and maintain S1 to S2 codemods in the future.
Codemods are now split up by component in
src/codemods/components/.So to add a Button codemod:
src/codemods/components/Button/transform.tsif it doesn't existremoveProp)__tests__/button.test.ts✅ Pull Request Checklist:
📝 Test Instructions:
Unit tests should validate that all the transforms are still correctly applied, but it would be good to build and test that it still works end-to-end:
cd packages/dev/codemods && yarn buildChange directories to an example app
node ../../packages/dev/codemods/dist/index.js s1-to-s2🧢 Your Project: