Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Corrected colorSwatch translation of ja-jp #7906

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ryokatsuse
Copy link

@ryokatsuse ryokatsuse commented Mar 11, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

I did not describe the issue, but since it is a minor fix, I submitted a pull request directly.
Changed the text of colorSwatch in ja-JP used in aria-roledescription of useColorSwatch.
In Japanese, it is commonly called “カラースイッチ” instead of “カラースウォッチ”.

If it is better to list the issue first, I will do so.

🧢 Your Project:

@snowystinger
Copy link
Member

Thanks for the PR, can you sign the CLA? https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement

@yihuiliao
Copy link
Member

In Japanese, it is commonly called “カラースウォッチ” instead of “カラースイッチ”

Just for clarification, did you mean that it's commonly called “カラースイッチ” instead of “カラースウォッチ”?

@ryokatsuse ryokatsuse closed this Mar 11, 2025
@ryokatsuse ryokatsuse reopened this Mar 11, 2025
@ryokatsuse
Copy link
Author

ryokatsuse commented Mar 11, 2025

@yihuiliao

In Japanese, it is commonly called “カラースウォッチ” instead of “カラースイッチ”

Just for clarification, did you mean that it's commonly called “カラースイッチ” instead of “カラースウォッチ”?

Thank you. You are right, Conversation was wrong, so I rewrote it.

@ryokatsuse ryokatsuse closed this Mar 11, 2025
@ryokatsuse ryokatsuse reopened this Mar 11, 2025
@dannify dannify requested a review from rgeraghty March 13, 2025 20:33
@dannify dannify added the i18n label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants