Skip to content

feat(RAC): add --trigger-width to Popovers used within DialogTrigger #7869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2025
Merged

feat(RAC): add --trigger-width to Popovers used within DialogTrigger #7869

merged 3 commits into from
Apr 16, 2025
+45 −4

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Mar 5, 2025 •
edited
Loading

Added to match ComboBox, DatePicker, DateRangePicker, Menu, and Select behavior.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check new story

🧢 Your Project:

@rspbot
Copy link

rspbot commented Mar 5, 2025

Build successful! 🎉

@devongovett
Copy link
Member

Makes sense. Should we add an example to storybook for testing?

@rspbot
Copy link

rspbot commented Apr 16, 2025

Build successful! 🎉

@reidbarber reidbarber added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 56d0e73 Apr 16, 2025
31 checks passed
@reidbarber reidbarber deleted the dialogtrigger-trigger-width branch April 16, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reidbarber @rspbot @devongovett @snowystinger @yihuiliao