fix: (WIP) Support React 19 and remove Jest reliance in test utils #7686
Conversation
| // else { | ||
| // // TODO: this is a bit unfortunate, but from a submenu point of view, we can't perform a check that waits for | ||
| // // focus to return to the original trigger since we don't have that information in the submenu trigger tester. Even if we did | ||
| // // it is a bit unpredicatable where focus might end up landing and waiting for the option/menu to disappear isn't sufficient if there are | ||
| // // more transitions in play. For now advance times by a certain amount of time and rely on the user to advance them even more if need be | ||
| // if (this._advanceTimer == null) { | ||
| // throw new Error('No advanceTimers provided for long press.'); | ||
| // } else { | ||
| // await act(async () => await this._advanceTimer(1000)); | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Did some poking around trying to get rid of the last jest.runAllTimers() here but no luck. The above is ok, but can extend test duration by quite a bit, also seemed to have some problems with hanging that I didn't quite figure out
|
ugh lint blew up, not sure why |
| @@ -29,7 +29,7 @@ export interface UserOpts { | |||
| * A function used by the test utils to advance timers during interactions. Required for certain aria patterns (e.g. table). This can be overridden | |||
| * at the aria pattern tester level if needed. | |||
| */ | |||
| advanceTimer?: (time?: number) => void | Promise<unknown> | |||
| advanceTimer?: (time?: number) => void | Promise<unknown> | any | |||
There was a problem hiding this comment.
the typing will need to be looked at again for advanceTimers, providing jest.runAllTimers as is threw some TS issues depending on the configuration.
| @@ -423,7 +423,7 @@ import {theme} from '@react-spectrum/theme-default'; | |||
| import {User} from '@react-spectrum/test-utils'; | |||
|
|
|||
| let testUtilUser = new User({interactionType: 'mouse'}); | |||
| // ... | |||
| // Other setup, be sure to check out the suggested mocks mentioned above in https://react-spectrum.adobe.com/react-spectrum/ListBox.html#testing | |||
There was a problem hiding this comment.
Hopefully makes it a little more clear that additional setup might be needed for RSP components in general
| "@testing-library/jest-dom": "^6.0.0", | ||
| "@testing-library/react": "^16.0.0", |
There was a problem hiding this comment.
Doesn't seem to have any breaking changes with this bump and the tests ran clean but will need to confirm on a React 19 project that the test utils work now
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: