fix(Toast): resume timers if no longer over toast region after a toast is removed #7681
+172
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
changed the title
reidbarber
changed the title
reidbarber
changed the title
| } | ||
| } | ||
| prevToastCount.current = currentCount; | ||
| }, [ref, state]); |
There was a problem hiding this comment.
Suggested change
| }, [ref, state]); | |
| }, [ref, state.visibleToasts, state.resumeAll]); |
There was a problem hiding this comment.
eslint[react-hooks/exhaustive-deps] still wants state here 🤔
There was a problem hiding this comment.
huh.... ok then i guess, that's so weird
could always pull them off the state object beforehand, the unfortunate part is that the state object will likely always be new, at least, until the react compiler can run on that file
| return () => { | ||
| document.removeEventListener('pointermove', onPointerMove); | ||
| }; | ||
| }, [state.visibleToasts.length]); |
There was a problem hiding this comment.
Suggested change
| }, [state.visibleToasts.length]); | |
| }, [state.visibleToasts]); |
just in case there's some situation where one is removed and one is added at the same time?
## API Changes
@react-aria/dnd/@react-aria/dnd:ClipboardProps ClipboardProps {
- getItems?: ({
- type: 'cut' | 'copy'
-}) => Array<DragItem>
+ getItems?: () => Array<DragItem>
isDisabled?: boolean
onCopy?: () => void
onCut?: () => void
onPaste?: (Array<DropItem>) => void@react-aria/utils/@react-aria/utils:createShadowTreeWalker-createShadowTreeWalker {
- doc: Document
- root: Node
- whatToShow?: number
- filter?: NodeFilter | null
- returnVal: undefined
-}/@react-aria/utils:ShadowTreeWalker-ShadowTreeWalker {
- constructor: (Document, Node, number, NodeFilter | null) => void
- currentNode: Node
- doc: Document
- filter: NodeFilter | null
- firstChild: () => Node | null
- lastChild: () => Node | null
- nextNode: () => Node | null
- previousNode: () => Node | null
- root: Node
- whatToShow: number
-}/@react-aria/utils:getActiveElement-getActiveElement {
- doc: Document
- returnVal: undefined
-}/@react-aria/utils:getEventTarget-getEventTarget {
- event: any
- returnVal: undefined
-}/@react-aria/utils:nodeContains-nodeContains {
- node: Node | null | undefined
- otherNode: Node | null | undefined
- returnVal: undefined
-}/@react-aria/utils:isShadowRoot-isShadowRoot {
- node: Node | null
- returnVal: undefined
-}@react-spectrum/s2/@react-spectrum/s2:Heading Heading {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
children?: ReactNode
- id?: string
isHidden?: boolean
level?: number
slot?: string | null
styles?: StyleString/@react-spectrum/s2:Header Header {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
children?: ReactNode
- id?: string
isHidden?: boolean
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Content Content {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
children?: ReactNode
- id?: string
isHidden?: boolean
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Footer Footer {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
children?: ReactNode
- id?: string
isHidden?: boolean
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Text Text {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
children?: ReactNode
- id?: string
isHidden?: boolean
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Keyboard Keyboard {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
children?: ReactNode
- id?: string
isHidden?: boolean
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Tabs Tabs {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children?: ReactNode
defaultSelectedKey?: Key
density?: 'compact' | 'regular' = 'regular'
disabledKeys?: Iterable<Key>
id?: string
isDisabled?: boolean
keyboardActivation?: 'automatic' | 'manual' = 'automatic'
- labelBehavior?: 'show' | 'hide' = 'show'
onSelectionChange?: (Key) => void
orientation?: Orientation = 'horizontal'
selectedKey?: Key | null
slot?: string | null
}/@react-spectrum/s2:TabList TabList <T extends {}> {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
- children?: ReactNode | (T) => ReactNode
+ aria-label?: string
+ aria-labelledby?: string
+ children?: ReactNode
dependencies?: Array<any>
items?: Iterable<T>
styles?: StylesProp
}/@react-spectrum/s2:Tab Tab {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
- children: ReactNode
+ children?: ReactNode
download?: boolean | string
href?: Href
hrefLang?: string
id?: Key
onHoverChange?: (boolean) => void
onHoverEnd?: (HoverEvent) => void
onHoverStart?: (HoverEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
styles?: StylesProp
target?: HTMLAttributeAnchorTarget
}/@react-spectrum/s2:ImageProps ImageProps {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
alt?: string
crossOrigin?: 'anonymous' | 'use-credentials'
decoding?: 'async' | 'auto' | 'sync'
- fetchPriority?: 'high' | 'low' | 'auto'
group?: ImageGroup
loading?: 'eager' | 'lazy'
referrerPolicy?: HTMLAttributeReferrerPolicy
renderError?: () => ReactNode
src?: string
styles?: StyleString
}/@react-spectrum/s2:TabsProps TabsProps {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children?: ReactNode
defaultSelectedKey?: Key
density?: 'compact' | 'regular' = 'regular'
disabledKeys?: Iterable<Key>
id?: string
isDisabled?: boolean
keyboardActivation?: 'automatic' | 'manual' = 'automatic'
- labelBehavior?: 'show' | 'hide' = 'show'
onSelectionChange?: (Key) => void
orientation?: Orientation = 'horizontal'
selectedKey?: Key | null
slot?: string | null
}/@react-spectrum/s2:TabProps TabProps {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
- children: ReactNode
+ children?: ReactNode
download?: boolean | string
href?: Href
hrefLang?: string
id?: Key
onHoverChange?: (boolean) => void
onHoverEnd?: (HoverEvent) => void
onHoverStart?: (HoverEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
styles?: StylesProp
target?: HTMLAttributeAnchorTarget
}/@react-spectrum/s2:TabListProps TabListProps <T> {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
- children?: ReactNode | (T) => ReactNode
+ aria-label?: string
+ aria-labelledby?: string
+ children?: ReactNode
dependencies?: Array<any>
items?: Iterable<T>
styles?: StylesProp
}@react-stately/data/@react-stately/data:TreeData TreeData <T extends {}> {
append: (Key | null, Array<{}>) => void
getItem: (Key) => TreeNode<{}> | undefined
insert: (Key | null, number, Array<{}>) => void
insertAfter: (Key, Array<{}>) => void
insertBefore: (Key, Array<{}>) => void
items: Array<TreeNode<{}>>
move: (Key, Key | null, number) => void
- moveAfter: (Key, Key | null, number) => void
- moveBefore: (Key, Key | null, number) => void
prepend: (Key | null, Array<{}>) => void
remove: (Array<Key>) => void
removeSelectedItems: () => void
selectedKeys: Set<Key>
update: (Key, {}) => void
}@react-stately/flags/@react-stately/flags:enableShadowDOM-enableShadowDOM {
- returnVal: undefined
-}/@react-stately/flags:shadowDOM-shadowDOM {
- returnVal: undefined
-} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7024
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: