Skip to content

Capstone/venn spec builder & react component #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

SantiagoG14
Copy link

@SantiagoG14 SantiagoG14 commented May 1, 2025

Description

New Venn feature

This PR adds a Venn diagram spec builder in the vega-spec-builder package, and a React component that renders the Venn in the react-spectrum-charts package. The vega-spec-builder package will use the library venn-helper to help create the spec of the Venn diagram.

Bug fixes

This PR also fixes a minor bug that prevented the autosize property in the chartProp config from being set properly.

useSpec changes

Adds a caching layer to the useSpec hook, making sure that it returns the cache if there is no Venn diagram child and that other deps that the Venn does not need have not changed. Based on our testing, we believe this change will not introduce unnecessary renders, but please let us know if you observe otherwise.

Motivation and Context

Users from Adobe Analytics were requesting a Venn diagram feature. This diagram will allow users to quickly understand relationships between data segments.

How Has This Been Tested?

We added new tests to each new file, testing for the important pieces for the Venn diagram to render correctly on the screen. All previous tests are also passing,

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SantiagoG14 SantiagoG14 changed the title DRAFT: Capstone/venn spec builder & react component Capstone/venn spec builder & react component May 1, 2025
Copy link

sonarqubecloud bot commented May 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
10 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants