-
Notifications
You must be signed in to change notification settings - Fork 20
Capstone/venn spec builder & react component #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SantiagoG14
wants to merge
18
commits into
adobe:main
Choose a base branch
from
SantiagoG14:capstone/vennSpecBuilder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Venn feature
This PR adds a Venn diagram spec builder in the vega-spec-builder package, and a React component that renders the Venn in the react-spectrum-charts package. The vega-spec-builder package will use the library venn-helper to help create the spec of the Venn diagram.
Bug fixes
This PR also fixes a minor bug that prevented the autosize property in the chartProp config from being set properly.
useSpec changes
Adds a caching layer to the
useSpec
hook, making sure that it returns the cache if there is no Venn diagram child and that other deps that the Venn does not need have not changed. Based on our testing, we believe this change will not introduce unnecessary renders, but please let us know if you observe otherwise.Motivation and Context
Users from Adobe Analytics were requesting a Venn diagram feature. This diagram will allow users to quickly understand relationships between data segments.
How Has This Been Tested?
We added new tests to each new file, testing for the important pieces for the Venn diagram to render correctly on the screen. All previous tests are also passing,
Screenshots (if appropriate):
Types of changes
Checklist: