Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support w3c working group design tokens spec #244

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Apr 19, 2024

Description

Cleaning up #228 on a new branch/pr.

Support w3c working group design tokens spec
All properties defined by this format are prefixed with the dollar sign ($). This convention will also be used for any new properties introduced by future versions of this spec.

Motivation

Support w3c working group design tokens spec in the output formatted tokens

Screenshot

image

To-do list

  • This pull request is ready to merge.

thierryc and others added 4 commits April 19, 2024 10:53
Removed unnecessary 'deg' units from HSL tokens to ensure correct parsing
by Style Dictionary.
Copy link

changeset-bot bot commented Apr 19, 2024

⚠️ No Changeset found

Latest commit: 781b248

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Apr 19, 2024

Run report for 781b2488

Total time: 20.5s | Comparison time: 18.8s | Estimated loss: 1.7s (8.5% slower)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
⬛️ SetupNodeTool(~20.11) 1.4s Skipped
🟩 InstallNodeDeps(~20.11) 6.5s Passed
🟩 SyncNodeProject(contrast-colors) 0.1ms Passed
🟩 SyncNodeProject(ui) 0.3ms Passed
🟩 RunTask(contrast-colors:test) 2.3s Passed
🟩 RunTask(ui:makeDistDir) 65.7ms Passed
🟩 RunTask(ui:copyCNAME) 58.5ms Passed
🟩 RunTask(ui:copyUIIcons) 58.5ms Passed
🟩 RunTask(ui:copyWorkflowIcons) 58.5ms Passed
🟩 RunTask(ui:buildSite) 10.2s Passed
Touched files
docs/ui/src/js/createOutputParameters.js
packages/contrast-colors/lib/utils.js
packages/contrast-colors/test/backgroundColor.test.js
packages/contrast-colors/test/convertColorValue.test.js
packages/contrast-colors/test/theme.test.js
packages/contrast-colors/test/themeSetters.test.js

@GarthDB GarthDB changed the title Thierryc patch 2 Support w3c working group design tokens spec Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants