Initial repository structure #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amuraru
reviewed
Jul 30, 2020
|
|
||
| ## Developer setup | ||
|
|
||
| * Golang 1.14 |
There was a problem hiding this comment.
Docker file updated
amuraru
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
looks good to me Alex.
I would also add a skeleton github action to start building/testing/pushing using that.
See https://github.com/adobe/kafka-operator/blob/master/.github/workflows/build-push-docker.yml
I think the same can be done for the helm chart as well right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial repository structure with core components in place. Next iterations we will start adding logic around scaling, updates to the charts, integration tests etc.