Adding Media Library to labs #172
Conversation
tools/media-library/scripts.js
Outdated
| } | ||
|
|
||
| async function fetchSitemap(sitemapURL) { | ||
| const fetchUrl = `https://little-forest-58aa.david8603.workers.dev/?url=${encodeURIComponent(sitemapURL)}`; |
There was a problem hiding this comment.
shouldn't we run this in our own POC CF space?
There was a problem hiding this comment.
This is the cors proxy that is being used in image audit . The web component will take a cors proxy as property so that host systems can use their own. The web component code it self uses the cors proxy deployed into poc space by default. Since this will be part of labs i thought it is better to use the existing cors proxy. Please let me know if that is not the case
tools/media-library/scripts.js
Outdated
| clearButton.style.display = display; | ||
| } | ||
|
|
||
| async function initializeMediaLibraryWithRetry(mediaLibrary, storageType) { |
There was a problem hiding this comment.
seems like we can combine this function with initializeMediaLibrary to be one function
There was a problem hiding this comment.
cleaned up and addressed
tools/media-library/scripts.js
Outdated
|
|
||
| setupStorageManager(mediaLibrary, siteKey); | ||
|
|
||
| await new Promise((resolve) => { |
There was a problem hiding this comment.
not a big fan of timeouts. Instead of a timeout, can we listen for a custom event to know when the media library has loaded and then based on that custom event we can do something when triggered?
There was a problem hiding this comment.
addressed in the new code. relying on the component ready event
https://github.com/kmurugulla/media-library-wc is the repository for web component . Added the un minified version of the web component script to deps and ignoring it from jslint |
|
@kmurugulla thanks for the fixes. I'd say let's wait to merge this for now as discussed. |
2 participants
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: