Merged
Conversation
added 9 commits
May 15, 2025 13:44
sdjustin
reviewed
May 16, 2025
| @@ -24,6 +24,10 @@ import { | |||
| CssSupportsAST, | |||
There was a problem hiding this comment.
suggestion: this a big file, maybe break it up into smaller modules?
- parse/parser.ts
- parse/tokenizer.ts
- parse/ast-builder.ts
There was a problem hiding this comment.
suggestion: maybe add some css input validations(i.e. check string type, size, etc.)
Author
There was a problem hiding this comment.
Yes, agree 👍 I'm not sure how the best way to break it down, but it will be better :-) I have already started to add some functions to another file for that purpose.
One thing to notice, though, performance is very important, so adding patterns like module class and so on will have a negative impact. So we should slowly find a way to split and refactor the file without introducing performance degradation, which makes it more challenging!
sdjustin
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
indexOfbase string searchRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: