Fix: Check last modified of resource using helix admin APIs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habansal
reviewed
Sep 29, 2023
| const entry = { path: entryPath }; | ||
|
|
||
| let date = await HelixAdminUtil.getLastModified(entryPath); | ||
| if (date === '') { |
There was a problem hiding this comment.
In what case will the Hlx Admin APIs not give the lastModified, but the CloudFlare CDN will provide?
I mean, do we need this if condition?
habansal
reviewed
Sep 29, 2023
|
|
||
| static getLastModified = async (path) => { | ||
| let lastModified = await HelixAdminUtil.getLastModifiedFromAdminAPIs(path, 'code'); | ||
| if (!lastModified && lastModified === '') { |
habansal
reviewed
Sep 29, 2023
| static helixAdminUrl = 'https://admin.hlx.page'; | ||
|
|
||
| static getLastModified = async (path) => { | ||
| let lastModified = await HelixAdminUtil.getLastModifiedFromAdminAPIs(path, 'code'); |
There was a problem hiding this comment.
Why do we need to check lastModified from .page url?
Shouldn't we check from just .live url?
habansal
reviewed
Sep 29, 2023
| @@ -148,6 +149,9 @@ export default class GenerateScreensOfflineResources { | |||
| lastModified: new Date(lastModified) | |||
| }; | |||
|
|
|||
| const hierarchy = PathUtils.getParentHierarchy(manifestData[i].path); | |||
| channelEntry.hierarchy = hierarchy; | |||
There was a problem hiding this comment.
is it related to this change?
What's the use of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for ticket SCRNS-3497
There seems to be an issue with the Cloudflare CDN. The last-modified in the franklin URLs are correct but incorrect in cloudflare CDN urls. Since we use custom domains from cloudflare, it's better to check helix admin APIs for the last modified values.
We can use helix admin APIs whichever give 200 status code to get the last modified.
https://admin.hlx.page/code/hlxscreens/sodexo/main/scripts/delayed.js
Or
https://admin.hlx.page/live/hlxscreens/sodexo/main/scripts/delayed.js
Related Issue
SCRNS-3497
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: