Skip to content

fix: render regular price if final is not provided or empty #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhaack wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: render regular price if final is not provided or empty #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/steps/render-body.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ import { maybeHTML } from './utils.js';
export function formatPrice(price) {
if (!price) return '';
const { regular, final } = price;
if (!final || final === '') {
return h('p', `$${regular}`);
}
if (parseFloat(final) < parseFloat(regular)) {
return h('p', [`$${final} `, '(', h('del', `$${regular}`), ')']);
}
Expand Down
28 changes: 21 additions & 7 deletions test/steps/render-body.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,6 @@ describe('formatPrice', () => {
assert.strictEqual(result.children[0].value, '$N/A');
});

it('displays final price when final is empty string', () => {
const result = formatPrice({ final: '', regular: '99.99' });
assert.strictEqual(result.tagName, 'p');
assert.strictEqual(result.children.length, 1);
assert.strictEqual(result.children[0].value, '$');
});

it('displays final price when regular is undefined', () => {
const result = formatPrice({ final: '79.99', regular: undefined });
assert.strictEqual(result.tagName, 'p');
Expand All @@ -172,6 +165,27 @@ describe('formatPrice', () => {
assert.strictEqual(result.children.length, 4);
assert.strictEqual(result.children[0].value, '$79.99abc ');
});

it('displays regular price when final is empty string', () => {
const result = formatPrice({ final: '', regular: '99.99' });
assert.strictEqual(result.tagName, 'p');
assert.strictEqual(result.children.length, 1);
assert.strictEqual(result.children[0].value, '$99.99');
});

it('displays regular price when final is undefined', () => {
const result = formatPrice({ final: undefined, regular: '99.99' });
assert.strictEqual(result.tagName, 'p');
assert.strictEqual(result.children.length, 1);
assert.strictEqual(result.children[0].value, '$99.99');
});

it('displays regular price when final is undefined', () => {
const result = formatPrice({ final: null, regular: '99.99' });
assert.strictEqual(result.tagName, 'p');
assert.strictEqual(result.children.length, 1);
assert.strictEqual(result.children[0].value, '$99.99');
});
});

describe('edge cases with zero', () => {
Expand Down
Loading