Hw2 #2
Open
Hw2 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
edikgoose
suggested changes
Mar 1, 2024
edikgoose
left a comment
edikgoose
left a comment
There was a problem hiding this comment.
Сделано хорошо. Из советов:
- Почитай про паттерны отказоустойчивости. Особенно про таймауты и ретраи (и обязательно добавь их в клиенты). Полезная тема для собесов.
- Дефолтный значения для параметров лучше указывать в том же конфиге (пример есть в одном замечании)
- Тестики все-таки стоит добавить
5/6
|
|
||
|
|
||
| public GitHubClient(String otherUrl) { | ||
| if (!otherUrl.isEmpty()) { |
There was a problem hiding this comment.
Лучше храни base-url в application.yaml конфиге в таком виде:
web-client:
github:
base-url: ${GITHUB_BASE_URL:https://...}
read-timeout: ${GITHUB_READ_TIMEOUT:1000}
write-timeout: ${GITHUB_WRITE_TIMEOUT:1000}
retry-count: ${GITHUB_RETRY_COUNT:5}
stackoverflow:
base-url: ... (the same) Тогда если не будет указан в env'е урлик, то он возьмет дефолтное значение после двоеточия
| public GitDTO fetch(String username, String repositoryName) { | ||
| return webClient.get().uri("/repos/%s/%s".formatted(username, repositoryName)) | ||
| .retrieve() | ||
| .bodyToMono(GitDTO.class) |
There was a problem hiding this comment.
Почитай про ретраи и как их применять. Полезная тема
| return webClient.get().uri(param -> param | ||
| .path("/questions/%d".formatted(questionId)) | ||
| .queryParam("site", "stackoverflow").build()) | ||
| .retrieve().bodyToMono(StackDTO.class).block(); |
|
|
||
| @Configuration | ||
| public class ClientConfiguration { | ||
| final ApplicationConfig config; |
| if (!otherUrl.isEmpty()) { | ||
| this.baseUrl = otherUrl; | ||
| } | ||
| this.webClient = WebClient.builder().baseUrl(otherUrl).build(); |
There was a problem hiding this comment.
Почитай про таймауты. Тоже важная тема для запросов
| public class ClientConfiguration { | ||
| final ApplicationConfig config; | ||
|
|
||
| @Value("${clients.github}") |
There was a problem hiding this comment.
Лучше создать property класс, где префиксом указать "clients". И инжектить уже его.
@ConfigurationProperties(prefix = "clients")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.