Feature/acquisition #382
Merged
Feature/acquisition #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix key retrieval for Html_RangeElementDescription writer class * fix br in rangeElement
rangeElements -> rangeElement
* make changes based on feedback found in release v2.18.5 branch * Fix evaluationMethod in mdJson * remove extra argument
type standaloneQualityReportDetails
This merge is not intended to have the tests passing yet, just adding the test action workflow file.
* Update Internal Object
* Fix Data Quality Order
* Fix Data Quality Order
* Fixing Legal Constraint Order
* Fix Allocation Order
* Fix Funding Order
* Fix Data Quality Order
* Update Data Quality Object
* And standaloneQualityReportDetails to mdJson Reader
* Fix Order
* Fix Standalone Quality Report
* Update Version for mdJson-schemas
* Add Quality Result File to Coverage Result
* Update Gemfile.lock
* Update nokogiri
* Rename standaloneQualityReport.rb
Need to fix naming case.
* Fix File Name
* Fix Typo
* Fix Internal Object
resultContent --> resultContentDescription and { } not [ ]
* Add Quality Result File to Coverage Result * add resultFile to coverageResult in mdJson reader (#331) * add resultFile to coverageResult in mdJson reader * remove pp lib * revert files * generate resourceFormat file and add to CR. fix metadata object in resultFile * fix internal metadata obj in resultFile * fix qualityResultFile class and reference * revert files * fix relative import * remove writer changes * Remove module_resourceFormat * Injection/md json writer cr (#332) * rename to qualityResultFile * add format and QualityResultFile classes to coverageResult in writer * revert files * add qualityResultFile * Fixed Names fileName was repeated in place of fileDescription and fileType. * Fix Result Content resultContent -> resultContentDescription Uses coverageDescription * Change nil? to empty? --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * Injection/html writer cr (#336) * add qualityMeasure to mdJson reader * fix qualityMeasure key * add resultFile class to dataQualityReport html writer * Fix Quality Measure Identifier needs to be built not directly assigned. * Improve Quality Measure Name and description will only be populated if they exist. --------- Co-authored-by: Jonathan Oliveros <[email protected]> * Injection/simple html writer cr (#335) * add dataQualityReport and resultFile classes * fix file format comment * reference resultFile class * change details to div * change details to div in dataQualityReport * change module to simple_html. Add nil or empty to citation within identifier. * add simple_html test * Add Coverage Result New class_qualityResultFile for iso19115-3 writer. * Fix Data Quality Report Fixed the order. Fixed quality measure. * Fix Quality Measure * Fix Quality Measure * Fix Evaluation Method * New Conformance Result ISO 19115-3 Writer --------- Co-authored-by: J-Oliveros <[email protected]> Co-authored-by: Jonathan Oliveros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #392
Closes #393
Changes
Version 2.20.0-beta.11
New Feature: Acquisitions
Internal
Readers
Writers