Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure timestamps #8

Merged
merged 43 commits into from
Mar 27, 2018
Merged

Structure timestamps #8

merged 43 commits into from
Mar 27, 2018

Conversation

silasmahler
Copy link
Member

@silasmahler silasmahler commented Mar 12, 2018

Hey @florianluediger, heres the present state 👍

What works now/has been done:

  • Generation of database-entries for (Spring)ApplicationContextEvents + storing and reading from in-memory-db
  • Generation of timemeasurements for testcontext (classes, methods) - TestBenchmarkclass
  • Annotate Testclass with @junitinsights if you want to use the features to measure the testclass and all its methods
  • Annotate Testmethods with @nojunitinsights if you dont want to measure a certain method

What was done why:

  • Measuring of ApplicationContexts was decoupled from measuring of Testcontexts cause it caused a ton of problems with the junit5 architecture
  • in junit extension no standard dependency injection is usable (Hence no @repository and @service -construct), so the context-store is used which problematically disappears after testexecution so the data needs to be saved properly

What has to be done:

@silasmahler
Copy link
Member Author

Fürs mergen können die Inhalte dieser branch genutzt werden

Copy link
Member

@florianluediger florianluediger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work fine so far, however before merging we also need to add the timestamps from the JUnit extension to the dataset and export the data in a csv file or something similar.

@silasmahler
Copy link
Member Author

This seems to work fine so far, however before merging we also need to add the timestamps from the JUnit extension to the dataset and export the data in a csv file or something similar.

Seems like a good option

@florianluediger
Copy link
Member

florianluediger commented Mar 16, 2018

After taking a step back, I realized that it is probably much easier to write the data directly into a csv file without the detour over the database. This also was really simple to implement and streamlined the code a fair bit. This is now ready for review and we can focus on the creation of the visual report from now.

Closes #4

@florianluediger florianluediger added the feature New functionality label Mar 23, 2018
@florianluediger florianluediger merged commit 23ee30a into master Mar 27, 2018
@florianluediger florianluediger deleted the structure_timestamps branch March 27, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants