test(csharp): add Statement.Cancel test#141
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the C# interop test suite by adding coverage for AdbcStatement.Cancel, and enhances the Snowflake test configuration helper to support additional authentication modes used by the interop tests.
Changes:
- Adds a new interop test validating
AdbcStatement.Cancelbehavior against a long-running Snowflake query. - Extends
SnowflakeTestingUtils.GetSnowflakeAdbcDriverto support JWT (key-pair) and OAuth authentication configuration. - Updates the interop test project file formatting and bumps
Microsoft.NET.Test.Sdkto18.5.1.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| csharp/test/Interop/StatementTests.cs | New test coverage for statement cancellation using SYSTEM$WAIT queries. |
| csharp/test/Interop/SnowflakeTestingUtils.cs | Adds JWT and OAuth auth parameter population for Snowflake interop tests. |
| csharp/test/Interop/AdbcDrivers.Snowflake.Interop.Tests.csproj | Updates test SDK package version and normalizes indentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
added 2 commits
June 1, 2026 17:38
…ub.com/adbc-drivers/snowflake into dev/birschick-bq/test-statement-cancel
CurtHagenlocher
approved these changes
Jun 2, 2026
| } | ||
|
|
||
| [SkippableFact] | ||
| public async Task CanCancelStatementTest() |
Collaborator
There was a problem hiding this comment.
Can I assume that this test would have failed before recent driver changes?
Collaborator
Author
There was a problem hiding this comment.
@CurtHagenlocher - You're correct. It would throw a NotSupported exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
arrow-adbchas been updated to latest.