Skip to content

test(csharp): add Statement.Cancel test#141

Merged
birschick-bq merged 16 commits into
mainfrom
dev/birschick-bq/test-statement-cancel
Jun 2, 2026
Merged

test(csharp): add Statement.Cancel test#141
birschick-bq merged 16 commits into
mainfrom
dev/birschick-bq/test-statement-cancel

Conversation

@birschick-bq

@birschick-bq birschick-bq commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

What's Changed

  • Added a test for Statement.Cancel
  • Adds support for key-pair and Oauth authentication in the test configuration file.
  • Updates Microsoft.NET.Test.Sdk reference to version 18.5.1
  • Corrects indentation in the project file.
  • Commit submodule reference to arrow-adbc has been updated to latest.

@birschick-bq birschick-bq requested review from davidhcoe and removed request for lidavidm and zeroshade June 1, 2026 23:56
@birschick-bq birschick-bq changed the title Dev/birschick bq/test statement cancel test(csharp): add Statement.Cancel test Jun 1, 2026
@birschick-bq birschick-bq changed the title test(csharp): add Statement.Cancel test test(csharp): add Statement.Cancel test Jun 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the C# interop test suite by adding coverage for AdbcStatement.Cancel, and enhances the Snowflake test configuration helper to support additional authentication modes used by the interop tests.

Changes:

  • Adds a new interop test validating AdbcStatement.Cancel behavior against a long-running Snowflake query.
  • Extends SnowflakeTestingUtils.GetSnowflakeAdbcDriver to support JWT (key-pair) and OAuth authentication configuration.
  • Updates the interop test project file formatting and bumps Microsoft.NET.Test.Sdk to 18.5.1.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
csharp/test/Interop/StatementTests.cs New test coverage for statement cancellation using SYSTEM$WAIT queries.
csharp/test/Interop/SnowflakeTestingUtils.cs Adds JWT and OAuth auth parameter population for Snowflake interop tests.
csharp/test/Interop/AdbcDrivers.Snowflake.Interop.Tests.csproj Updates test SDK package version and normalizes indentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread csharp/test/Interop/StatementTests.cs Outdated
Comment thread csharp/test/Interop/StatementTests.cs Outdated
Comment thread csharp/test/Interop/SnowflakeTestingUtils.cs
birschick-bq and others added 2 commits June 1, 2026 17:08
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@birschick-bq birschick-bq marked this pull request as draft June 2, 2026 00:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Comment thread csharp/test/Interop/SnowflakeTestingUtils.cs Outdated
Comment thread csharp/test/Interop/SnowflakeTestingUtils.cs Outdated
Comment thread csharp/test/Interop/SnowflakeTestingUtils.cs Outdated
Comment thread csharp/test/Interop/StatementTests.cs
Comment thread csharp/test/Interop/StatementTests.cs Outdated
Comment thread csharp/test/Interop/Resources/snowflakeconfig.json Outdated
birschick-bq and others added 5 commits June 1, 2026 17:33
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Bruce Irschick (Bit Quill Technologies Inc) added 2 commits June 1, 2026 17:38
@birschick-bq birschick-bq marked this pull request as ready for review June 2, 2026 00:41
}

[SkippableFact]
public async Task CanCancelStatementTest()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I assume that this test would have failed before recent driver changes?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CurtHagenlocher - You're correct. It would throw a NotSupported exception.

@birschick-bq birschick-bq merged commit 20d8b54 into main Jun 2, 2026
4 of 5 checks passed
@birschick-bq birschick-bq deleted the dev/birschick-bq/test-statement-cancel branch June 2, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants