fix(csharp): emit bare hostname for telemetry host_url to match JDBC#473
Closed
jadewang-db wants to merge 1 commit into
Closed
fix(csharp): emit bare hostname for telemetry host_url to match JDBC#473jadewang-db wants to merge 1 commit into
jadewang-db wants to merge 1 commit into
Conversation
driver_connection_params.host_info.host_url was emitted as "https://<host>:443", differing from JDBC which emits a bare hostname. Analysts joining on host across drivers had to normalize. Port is already reported separately in host_info.port (PECO-2982), so the scheme and redundant :443 suffix served no purpose. Closes PECO-2987. Co-authored-by: Isaac
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
driver_connection_params.host_info.host_urlwas emitted as"https://<host>:443", differing from JDBC which emits a bare hostname (e.g.host.cloud.databricks.com). Analysts joining on host across drivers had to normalize. Port is already reported separately inhost_info.port(PECO-2982), so the scheme +:443suffix served no purpose.Change
csharp/src/Telemetry/ConnectionTelemetry.cs: emit barehostinstead of$"https://{host}:{port}"forHostUrl.host_info.host_url"https://host.cloud.databricks.com:443""host.cloud.databricks.com"host_info.port443443(unchanged)Test plan
ConnectionParams_HostInfoHostUrl_IsBareHostnameincsharp/test/E2E/Telemetry/ConnectionParametersTests.csverifying the host_url matches the bare hostname from connection properties.ClientTelemetryE2ETestsassertion fromAssert.Contains("https://", ...)toAssert.DoesNotContain("://", ...).csharp/doc/telemetry-design.mdanddocs/designs/fix-telemetry-gaps-design.mdexample payloads + validation rules.dotnet test --filter "FullyQualifiedName~Unit."suite: 638 passed.Stack
This is the base of a 2-PR stack. PR #456 (PECO-3021, enable_fast_metadata_query) will be re-targeted onto this branch once merged.
Closes PECO-2987.