Add OKLab color space support#43
Merged
Merged
Conversation
OKLab provides superior perceptual uniformity compared to CIELAB, where Euclidean distance directly corresponds to perceived color difference. This enables more accurate color mapping for dimensionality reduction. Changes: - Add generate_oklab_grid() and oklab_to_rgb_vectorized() to ucie.py - Add OKLAB as a target for optimize_embedding() - Add assign_colours_oklab() function to core.py - Add OKLAB to CLI colormap choices and default 3D colormap list - Export assign_colours_oklab in package __init__.py - Add comprehensive tests for all new OKLab functionality Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
generate_oklab_grid(),oklab_to_rgb_vectorized(), updatedget_target_hull()andoptimize_embedding()to support OKLAB targetassign_colours_oklab()function, added OKLAB to CLI choices and default 3D colormap listassign_colours_oklabUsage
Test plan
🤖 Generated with Claude Code