-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select proper default for output_field
based on distinct value
#647
base: main
Are you sure you want to change the base?
Select proper default for output_field
based on distinct value
#647
Conversation
Co-Authored-By: Adam Johnson <[email protected]>
I believe that all functional tests succeed, but have no idea neither why the py38-multilint complains nor how to fix that particular error. |
The error:
Run black on the file to fix that. |
So thinking about how we release this - it's a small breaking change. I think it will need a major version bump to communicate this, so I'd like to batch it with some other breaking changes I've not got around to making. |
@javiplx It'll be faster if you run |
Finally !!!! |
b13f652
to
ada23ea
Compare
Will return a set when distinct is enabled, and a list otherwise