-
Notifications
You must be signed in to change notification settings - Fork 51
Fix: I2C Scan on ESP32-S2 #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Noting that this needs to be re-built and re-tested after adafruit/ci-arduino#210 is merged. We will want to cut a new release for Beta 98 after this. |
@tyeth Tested again on ESP32-S2 Feather. Please give it a test and ✅ when done! |
|
Noting that we removed a call to WIRE's |
This pull request in conjunction with adafruit/ci-arduino#210 should fix the broken I2C scanning present on ESP32-S2 platforms running WipperSnapper Beta 96 or Beta 97.
This pull request also:
scanAddresses
to match Espressif's I2C Scan TestTested on Adafruit Feather ESP32-S2 w/BME280
Requires adafruit/ci-arduino#210 to be merged in and this PR to be rebuilt before testing again
Resolves - #700