Support color depth for 8 colors screen #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggfly
changed the title
eggfly
force-pushed
the
master
branch
2 times, most recently
from
8ddfa25 to
3f5aac5
Compare
|
All check passed, please take some time to do a review :) |
|
@ladyada Hi! Can you assign any team member to review this PR? Thanks! |
|
hi please start by not changing the object instantiation argument order - thanks! :) |
eggfly
force-pushed
the
master
branch
2 times, most recently
from
9d9c7fc to
f988367
Compare
Replace LS013B7DH06 from Breakout Board and tested. It needs tripled RAM size than mono screen.
|
@ladyada Modified argument order, done! |
|
Ping! Adafruit does not has a product that uses LS013B7DH06 3 bits color screen, so this PR can't be merge? Is that the reason? |
|
no, we dont have one. do you have a monochrome display you can verify it still works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace LS013B7DH06 from Breakout Board and tested.
It needs tripled RAM size than mono screen.
I added support for color depth because sharp sells a memory LCD with a color depth of 3. I have tested this library on that LCD with a feather m0 and it works. The part number for this LCD is LS013B7DH06 and is compatible with existing sharp memory LCD breakout boards.