Ocelots - Larissa A. #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r by area, clothing by fabric, electronics by type)
| @@ -1,0 +1,8 @@ | |||
| conditions = { | |||
There was a problem hiding this comment.
Nice use of dict for this! O(1) lookup vs worst case O(n) for n conditions for an if/else to fall through to the last condition!
| def check_valid_id(self, id): | ||
| if type(id) == int: | ||
| return id | ||
| elif str(id).isnumeric(): |
There was a problem hiding this comment.
nice type conversation attempt with error checking!
| - (obj) item with id or None | ||
| """ | ||
| result = list(filter(lambda item: item.id == id, self.inventory)) |
There was a problem hiding this comment.
nice use of lambda with filter here!
|
|
||
| def swap_items(self, other_vendor, my_item, their_item): | ||
| """ | ||
| Swaps two indicated items between vendors. |
| their_item not in other_vendor.inventory): | ||
| return False | ||
| else: | ||
| self.remove(my_item) |
There was a problem hiding this comment.
well done making use of existing vendor functions, rather than reimplementing the logic here
| :returns: | ||
| - (bool) True if swapped or False | ||
| """ | ||
| [vendor.display_inventory(category) for vendor in [self, other_vendor]] |
|
|
||
| # ~~~~~ swap_by_category_attribute Tests ~~~~~ | ||
| # ~~~~~ swap decor by area Tests ~~~~~ | ||
| def test_swap__when_no_matching_area_returns_false(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.