Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 175 additions & 0 deletions src/adagrams.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,190 @@
export const drawLetters = () => {

// Implement this method for wave 1

// Create empty array for pool of letters
const letterPool = [];

// Create object to hold letter counts
const letterCounts = {
'A': 9,
'B': 2,
'C': 2,
'D': 4,
'E': 12,
'F': 2,
'G': 3,
'H': 2,
'I': 9,
'J': 1,
'K': 1,
'L': 4,
'M': 2,
'N': 6,
'O': 8,
'P': 2,
'Q': 1,
'R': 6,
'S': 4,
'T': 6,
'U': 4,
'V': 2,
'W': 2,
'X': 1,
'Y': 2,
'Z': 1
}

// Populate letterPool with correct number of each letter
for (let [key,value] of Object.entries(letterCounts)) {
for (let i = 0; i < value; ++i) {
letterPool.push(key);
}
}
Comment on lines +39 to +43

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice solution for ensuring we get the desired distribution of letters.

I would consider moving the creation of the letterPool variable to directly above this loop to keep it right next to where it gets used.


// Shuffle the letterPool and return selection of 10 letters
const shuffle = function (letterPool) {
letterPool.sort(() => Math.random() - 0.5);
}
Comment on lines +46 to +48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really neat implementation 😄


shuffle(letterPool);
const letterPoolSelection = letterPool.slice(0, 10);
return letterPoolSelection;
};

export const usesAvailableLetters = (input, lettersInHand) => {

// Implement this method for wave 2

let word = input.toUpperCase();

// Create object of letter frequency for lettersInHand
const letterBankCount = {}

for (const letter of lettersInHand) {
if (letter in letterBankCount) {
letterBankCount[letter] += 1;
} else {
letterBankCount[letter] = 1;
}
}

// Create object of letter frequency for word
const wordCount = {}

for (const letter of word) {
if (letter in wordCount) {
wordCount[letter] += 1;
} else {
wordCount[letter] = 1;
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of frequency maps.


// Check that word letter frequency complies with lettersInHand
for (const key in wordCount) {
if (!(key in letterBankCount)) {
return false;
}
if (wordCount[key] > letterBankCount[key]) {
return false;
}
Comment on lines +85 to +90

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the line doesn't get too long, I suggest combining these into one if-statement so we can have one false return.

}
return true;
};

export const scoreWord = (word) => {

// Implement this method for wave 3
if (word === '') {
return 0;
}

word = word.toUpperCase();

let points = 0;
Comment on lines +102 to +104

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider moving these lines to below scoreChart, or at least the initialization of points so they are right next to where they get used. This can make reading easier since there's no need to scroll if you have to remind yourself of what a value was initialized as.


// Create object to hold scoreChart
const scoreChart = {
'A': 1,
'B': 3,
'C': 3,
'D': 2,
'E': 1,
'F': 4,
'G': 2,
'H': 4,
'I': 1,
'J': 8,
'K': 5,
'L': 1,
'M': 3,
'N': 1,
'O': 1,
'P': 3,
'Q': 10,
'R': 1,
'S': 1,
'T': 1,
'U': 1,
'V': 4,
'W': 4,
'X': 8,
'Y': 4,
'Z': 10
}

// Calculate score for each word
for (const letter of word) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of a for...of loop.

points += scoreChart[letter];
}
Comment on lines +137 to +139

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have an unexpected result if the string word has characters that aren't in scoreChart. If we have an input like "ABC DEF" then points will hold NaN (Not a Number) after the loop. If we wanted to skip non-alphabetic characters or characters that aren't in scoreChart, how could we do that?


if (word.length >= 7 && word.length <= 10) {
points += 8;
}

return points;

};

export const highestScoreFrom = (words) => {

// Implement this method for wave 4

// Create object to hold scores
const scores = {};

// Populate scores with word scores
for (let word of words) {
word = word.toUpperCase();
if (!(word in scores)) {
scores[word] = scoreWord(word)
}
}

let highestScore = 0;
let winner;

// Determine highestScore and winner
for (const wordEntry in scores) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation to tie break in a single loop!


if (scores[wordEntry] > highestScore) {
highestScore = scores[wordEntry];
winner = wordEntry;
} else if (scores[wordEntry] === highestScore) {
if (winner.length === 10) {
break;
} else if (wordEntry.length === 10 || wordEntry.length < winner.length) {
winner = wordEntry;
}
}
}

// Create winner object
const winningObject = {
"word": winner,
"score": scores[winner],
}

return winningObject;

};
8 changes: 5 additions & 3 deletions test/adagrams.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ describe("Adagrams", () => {
});

it("returns a score of 0 if given an empty input", () => {
throw "Complete test";
expectScores({
'': 0,
});
});

it("adds an extra 8 points if word is 7 or more characters long", () => {
Expand All @@ -133,7 +135,7 @@ describe("Adagrams", () => {
});
});

describe.skip("highestScoreFrom", () => {
describe("highestScoreFrom", () => {
it("returns a hash that contains the word and score of best word in an array", () => {
const words = ["X", "XX", "XXX", "XXXX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };
Expand All @@ -145,7 +147,7 @@ describe("Adagrams", () => {
const words = ["XXX", "XXXX", "X", "XX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };

throw "Complete test by adding an assertion";
expect(highestScoreFrom(words)).toEqual(correct);
});

describe("in case of tied score", () => {
Expand Down
2 changes: 1 addition & 1 deletion test/demo/model.test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Model from 'demo/model';
import Adagrams from 'demo/adagrams';

describe.skip('Game Model', () => {
describe('Game Model', () => {
const config = {
players: [
'Player A',
Expand Down