Correct datatypes for string expressions

[DuDaAG]

Ich weiß leider immer noch nicht, wie ich ich zum Testen ein Literal mit Datatype erzeugen kann.

Also in Zeile ExportExecutionTreesTest.cpp Zeile 1678 + Zeile 1686.

Gibt es hier in Github die Möglichkeit, dass ich zu einzelnen Codestellen Kommentare (Fragen an dich) einfüge, damit es übersichtlicher ist. Ich habe die Funktion nur in den einzelnen Commits gefunden, aber bis man die dann findet. Also wie mache ich es am besten?

[codecov]

Codecov Report

Attention: Patch coverage is 77.55102% with 33 lines in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (6fba76f) to head (0c41603).
Report is 36 commits behind head on master.

Files with missing lines	Patch %	Lines
...sparqlExpressions/SparqlExpressionValueGetters.cpp	28.57%	10 Missing ⚠️
src/engine/ExportQueryExecutionTrees.cpp	83.92%	3 Missing and 6 partials ⚠️
src/engine/sparqlExpressions/StringExpressions.cpp	83.67%	7 Missing and 1 partial ⚠️
...e/sparqlExpressions/SparqlExpressionValueGetters.h	33.33%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1636      +/-   ##
==========================================
+ Coverage   89.25%   89.57%   +0.32%     
==========================================
  Files         372      383      +11     
  Lines       34818    37023    +2205     
  Branches     3931     4186     +255     
==========================================
+ Hits        31076    33165    +2089     
- Misses       2470     2547      +77     
- Partials     1272     1311      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joka921]

Hi, You can above click at Files changed, then you get the changed files (by default from all commits, which is fine for what you want), then you can select rows and attach comments to those. Make sure to finish your(self-review) if the comments are marked as "pending", because otherwise we cannot see them.

[joka921]

A first round on everything but the tests.
Work on my comments, and contact me once you are done or are left with questions.

[sonarcloud]

Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[joka921]

Another round of reviews, this is really improving.
Make sure that the continuous integration runs through (in particular no warnings in the code + formatting etc.)

[joka921]

There is a lot of code duplication here.
As a first step you can factor out the calls to idToLiteralOrIri (write a lambda that does this for you, such that the calls get shorter.

Then you can look up the gtest matchers ::testing::Optional and ::testing::ResultOf to get this shorter (the googletest documentation, or the rest of the codebase can give you hints, otherwise contact me.

[sparql-conformance]

Conformance check passed ✅

Test Status Changes 📊

Number of Tests	Previous Status	Current Status
2	Failed	Intended

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=be80b0904533d081d33908944fafdfabef7c3eb0&prev=4a159948af0b56472898e34392754141c68e07cf