Correct datatype and language tag for the result of SUBSTR

[DuDaAG]

If the input string of the SUBSTR function has a language tag, then according to the SPARQL standard the result has to preserve this language tag. Same goes if the datatype of the string is xsd:string. This PR implements this behavior (previously the language tag and datatype were always dropped) and implements all the infrastructure to implement this behavior also for other expressions that take and return strings.

[codecov]

Codecov Report

Attention: Patch coverage is 94.92754% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (635c288) to head (a0beee6).
Report is 7 commits behind head on master.

Files with missing lines	Patch %	Lines
src/engine/ExportQueryExecutionTrees.cpp	88.88%	4 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #1636    +/-   ##
========================================
  Coverage   90.60%   90.61%            
========================================
  Files         405      405            
  Lines       39732    39903   +171     
  Branches     4488     4509    +21     
========================================
+ Hits        36001    36157   +156     
- Misses       2397     2405     +8     
- Partials     1334     1341     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[joka921]

Hi, You can above click at Files changed, then you get the changed files (by default from all commits, which is fine for what you want), then you can select rows and attach comments to those. Make sure to finish your(self-review) if the comments are marked as "pending", because otherwise we cannot see them.

[joka921]

A first round on everything but the tests.
Work on my comments, and contact me once you are done or are left with questions.

[joka921]

Another round of reviews, this is really improving.
Make sure that the continuous integration runs through (in particular no warnings in the code + formatting etc.)

[sonarqubecloud]

Quality Gate failed

Failed conditions
5.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[joka921]

Some additional comments.

[joka921]

A pass on everything but the tests,
This looks really nice except for the one bug.

[joka921]

I like this much better,
One and a half additional rounds or so and we can merge this.
Let me know if you have additional questions.

[joka921]

The result variable is never used.
What about taking the isiString just as a muytable reference
(void replaceAngle(string& iriString))

[DuDaAG]

If I implement this, I get the following error message:
error: cannot bind non-const lvalue reference of type ‘std::string&’ {aka ‘std::__cxx11::basic_string&’} to an rvalue of type ‘std::remove_reference<std::__cxx11::basic_string&>::type’ {aka ‘std::__cxx11::basic_string’}
397 | std::move(word.getIri().toStringRepresentation())));
Does this mean that the I have to work with a copy either in replaceAngle or in handleIriOrLiteral?

[joka921]

If an argument is a non-const lvalue-reference like std::string& you can not assign a temporary or the result of std::move() (an rvalue reference) to this parameter. It would also be pointless, because you would mutate something in place, that is then discarded. With the reference you would have to do something like

auto str = std::move(w.Iri.toStringRepr());
replaceAngles(str);
auto Iri = Iri::fromStringRepr(std::move(str))

Whichy at second glance is ugly and doesn't really save anything here, so we just leav your original version.

[joka921]

The mutable reference would be a better interface for the abstract interface of the class, but not for its only usage here:)

[joka921]

Thank you very much,
This looks great now.

[sparql-conformance]

Conformance check passed ✅

Test Status Changes 📊

Number of Tests	Previous Status	Current Status
2	Failed	Intended

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=a0beee6d8fbea64eab7f8527778764107c78f53e&prev=54e9f8b562628982a1e07e418ac05070a66bffaa

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud