Make MIN_WORD_PREFIX_SIZE configurable
#1534
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the `MIN_WORD_PREFIX_SIZE` was not only hard-coded in `src/global/Constants.h`, but there was also code in `src/index/IndexImpl.Text.cpp` that only worked for the hard-coded value. The latter code is now generic. TODO: Make `MIN_WORD_PREFIX_SIZE` configurable from the command line. Joint work with @Qup42
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1534 +/- ##
==========================================
- Coverage 88.18% 88.18% -0.01%
==========================================
Files 359 359
Lines 27061 27064 +3
Branches 3655 3653 -2
==========================================
+ Hits 23865 23867 +2
Misses 1951 1951
- Partials 1245 1246 +1 ☔ View full report in Codecov by Sentry. |
|
Qup42
reviewed
Oct 2, 2024
Comment on lines
+495
to
+496
| if (std::all_of(prefix.begin(), prefix.end(), | ||
| [firstChar](char c) { return c == firstChar; })) { |
There was a problem hiding this comment.
Suggested change
| if (std::all_of(prefix.begin(), prefix.end(), | |
| [firstChar](char c) { return c == firstChar; })) { | |
| if (std::ranges::all_of(prefix, | |
| [firstChar](char c) { return c == firstChar; })) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the
MIN_WORD_PREFIX_SIZEwas not only hard-coded insrc/global/Constants.h, but there was also code insrc/index/IndexImpl.Text.cppthat only worked for the hard-coded value. The latter code is now generic.TODO: Expand test + make
MIN_WORD_PREFIX_SIZEconfigurable from the command line.Co-authored-by: Julian Mundhahs [email protected]