refactor(Button): align with Mantine API using leftSection/rightSection#7
Open
beaucalvez wants to merge 1 commit intomainfrom
Open
refactor(Button): align with Mantine API using leftSection/rightSection#7beaucalvez wants to merge 1 commit intomainfrom
beaucalvez wants to merge 1 commit intomainfrom
Conversation
- Replace leftIcon/rightIcon props with leftSection/rightSection to match Mantine's official API - Update Button.figma.tsx to use hasLeftSection/hasRightSection properties - Update CloseButton.figma.tsx to import from local DS component instead of @mantine/core - Update Figma URL references to correct node IDs (Button: 5331-12700, CloseButton: 1298-2247) - Improve prop documentation to reflect generic content vs icon-specific usage This change improves consistency with Mantine v7+ API and makes the component more flexible for non-icon content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
leftSection/rightSectionprops instead ofleftIcon/rightIconto align with Mantine v7+ official APIhasLeftSection/hasRightSectionpropertiesChanges
Button Component
leftIconandrightIconprops fromDSButtonPropsinterfaceleftSectionandrightSectionprops with improved documentation</ADDSButton>→</Button>)hasLeftIcontohasLeftSectionButton Code Connect
5331-12700hasIconLeft/hasIconRighttohasLeftSection/hasRightSectionCloseButton Code Connect
@mantine/coreto local DS component./CloseButtonBenefits
Test Plan