Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set how far out the upcoming scheduled transactions are shown in the account view. #3310

Conversation

SamBobBarnes
Copy link
Contributor

Add option to set how far out the upcoming scheduled transactions are shown in the account view.
This option can be set to 1, 7, 14, or 30 days out from today.

The only thing lacking from this enhancement, that I couldn't work out how to implement, was longer periods (eg 2-3 mo) because I couldn't work out how to show more than just the next instance of a scheduled transaction. This may also be an issue if a user has scheduled transactions that should occur more than once per visible period.

I implemented this enhancement because I was frustrated that I could only see 7 days into the future and could not plan ahead very far into the future. This is something that I wanted because I was moving from quicken where I utilized seeing a month in the future often for planning purposes.

@actual-github-bot actual-github-bot bot changed the title Add option to set how far out the upcoming scheduled transactions are shown in the account view. [WIP] Add option to set how far out the upcoming scheduled transactions are shown in the account view. Aug 24, 2024
Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 8c96f73
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6708a509c50100000851ef70
😎 Deploy Preview https://deploy-preview-3310.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Aug 24, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 5.32 MB → 5.34 MB (+17.84 kB) +0.33%
Changeset
File Δ Size
node_modules/glamor/lib/jsxstyle.js 🆕 +14.74 kB 0 B → 14.74 kB
src/components/settings/Upcoming.tsx 🆕 +2.37 kB 0 B → 2.37 kB
node_modules/glamor/jsxstyle.js 🆕 +26 B 0 B → 26 B
node_modules/glamor/lib/jsxstyle.js?commonjs-exports 🆕 +20 B 0 B → 20 B
src/components/schedules/index.tsx 📈 +353 B (+11.95%) 2.89 kB → 3.23 kB
home/runner/work/actual/actual/packages/loot-core/src/client/data-hooks/schedules.tsx 📈 +131 B (+5.76%) 2.22 kB → 2.35 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/schedules.ts 📈 +46 B (+0.87%) 5.15 kB → 5.19 kB
src/components/budget/BudgetPageHeader.tsx 📈 +4 B (+0.58%) 692 B → 696 B
src/components/budget/IncomeHeader.tsx 📈 +4 B (+0.45%) 890 B → 894 B
src/components/filters/FiltersStack.tsx 📈 +4 B (+0.40%) 994 B → 998 B
src/components/budget/RenderMonths.tsx 📈 +2 B (+0.29%) 684 B → 686 B
src/components/accounts/Reconcile.tsx 📈 +14 B (+0.26%) 5.19 kB → 5.2 kB
src/components/gocardless/GoCardlessLink.tsx 📈 +2 B (+0.22%) 907 B → 909 B
src/components/budget/SidebarCategory.tsx 📈 +10 B (+0.20%) 4.95 kB → 4.96 kB
src/components/budget/BudgetTotals.tsx 📈 +6 B (+0.19%) 3.16 kB → 3.16 kB
src/components/budget/MonthPicker.tsx 📈 +8 B (+0.18%) 4.44 kB → 4.45 kB
src/components/budget/SidebarGroup.tsx 📈 +10 B (+0.17%) 5.63 kB → 5.64 kB
src/components/budget/BudgetTable.jsx 📈 +10 B (+0.16%) 6.01 kB → 6.02 kB
src/components/accounts/Header.jsx 📈 +28 B (+0.16%) 17.04 kB → 17.06 kB
src/components/budget/ExpenseGroup.tsx 📈 +4 B (+0.16%) 2.49 kB → 2.49 kB
src/components/budget/DynamicBudgetTable.tsx 📈 +4 B (+0.14%) 2.88 kB → 2.88 kB
src/components/budget/ExpenseCategory.tsx 📈 +2 B (+0.10%) 1.89 kB → 1.89 kB
src/components/budget/BudgetSummaries.tsx 📈 +2 B (+0.09%) 2.25 kB → 2.25 kB
src/components/accounts/Balance.jsx 📈 +4 B (+0.07%) 5.43 kB → 5.43 kB
src/components/budget/BudgetCategories.jsx 📈 +6 B (+0.07%) 8.53 kB → 8.53 kB
src/components/budget/index.tsx 📈 +4 B (+0.04%) 8.8 kB → 8.8 kB
src/components/transactions/TransactionsTable.jsx 📈 +28 B (+0.04%) 63.55 kB → 63.57 kB
src/components/filters/SavedFilterMenuButton.tsx 📈 +2 B (+0.04%) 5 kB → 5 kB
src/components/accounts/Account.tsx 📈 +12 B (+0.03%) 43.78 kB → 43.79 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide.js 225.28 kB → 242.95 kB (+17.66 kB) +7.84%
static/js/index.js 3.34 MB → 3.34 MB (+177 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/usePreviewTransactions.js 1.64 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/AppliedFilters.js 20.96 kB 0%
static/js/narrow.js 82.55 kB 0%
static/js/ReportRouter.js 1.51 MB 0%

Copy link
Contributor

github-actions bot commented Aug 24, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.26 MB → 1.26 MB (+141 B) +0.01%
Changeset
File Δ Size
packages/loot-core/src/server/prefs.ts 📈 +96 B (+4.70%) 2 kB → 2.09 kB
packages/loot-core/src/server/schedules/app.ts 📈 +270 B (+1.56%) 16.89 kB → 17.16 kB
packages/loot-core/src/shared/schedules.ts 📈 +46 B (+0.50%) 9.06 kB → 9.1 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.26 MB → 1.26 MB (+141 B) +0.01%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@SamBobBarnes SamBobBarnes changed the title [WIP] Add option to set how far out the upcoming scheduled transactions are shown in the account view. Add option to set how far out the upcoming scheduled transactions are shown in the account view. Aug 25, 2024
@youngcw
Copy link
Member

youngcw commented Aug 27, 2024

Could the setting live somewhere other than the settings page? Like in the schedules page?

@joel-jeremy
Copy link
Contributor

This setting should be moved to the schedule creation form IMO. We could have a "Remind me X days ahead" setting which can be different per schedule.

@youngcw youngcw merged commit 37ad584 into actualbudget:master Oct 11, 2024
20 checks passed
@SamBobBarnes
Copy link
Contributor Author

@youngcw ill make a pr to add that text this weekend. Been busy the last couple days with a hackathon. Thanks for taking care of this tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants