Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac(map): Update attribution text to condensed version and change profile on key press [p] #969

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

wkyoshida
Copy link
Member

Contributor checklist


Description

Slowly but surely chipping away at some map stuff..

  • Was confused by the keydown event on [x] causing both the clearing of directions and toggling the route profile. Modified so that the route profile is changed instead on keydown events on [p]. Let me know if there was a reason though for having both actions caused by the same event - wasn't sure
  • As per part of the discussion in map: attribution not fully responsive #961, modified the attribution texts to be more condensed. Went with:
    • © OpenStreetMap as that is also a fairly common alternative (ref).
    • CyclOSM hosted by OSM France as opposed to CyclOSM tiles by OSM France from map: attribution not fully responsive #961 (comment) , given that I'm actually unsure if the CyclOSM styles are officially an OSM France project. However, the tiles themselves are definitely hosted by their infrastructure - so that seemed more appropriate.

Also - as I was looking at this, thought about how eventually using localized strings for the map controls/interactions would be a good idea actually - created #968 for it.

Related issue

Copy link
Contributor

github-actions bot commented Sep 8, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 62d1b6e
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66dd17df5799a40008adc2cc
😎 Deploy Preview https://deploy-preview-969--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working really well, @wkyoshida, and thanks for adding in the hotkey for the profiles! I think that the route profile update on x likely came from @GrandSuccess87 and I trying things back when we were first getting it to work.

Coming along so nicely! 🗺️

@andrewtavis andrewtavis merged commit be71c3b into activist-org:main Sep 8, 2024
7 checks passed
@wkyoshida wkyoshida deleted the 961-a branch September 9, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants