Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and add missing key to the keys list #966

Conversation

jennethydyrova
Copy link
Contributor

Contributor checklist


Description

  1. Renamed components.meta-tag-video.view-vide to components.card_search_result.view_video to match new naming convention.
  2. Added renamed key to the list of keys as it was missing.

Related issue

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit e107c56
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66d716def9b91e0008400dc3
😎 Deploy Preview https://deploy-preview-966--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jennethydyrova jennethydyrova mentioned this pull request Sep 3, 2024
2 tasks
@jennethydyrova
Copy link
Contributor Author

The pipeline is failing because of some invalid i18n keys, I can fix them in this PR if that's okay, @andrewtavis?

@andrewtavis
Copy link
Member

Sure thing, makes sense, @jennethydyrova! :) Please do fix them as directed by the errors. Means that the refactoring we recently did worked out :)

@andrewtavis andrewtavis self-requested a review September 3, 2024 12:35
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate you keeping up with the localization upkeep, @jennethydyrova! Would be interested in getting your feedback on the progress. Let me know if you think some things should be changed or if we can improve the process somehow 😊

@andrewtavis andrewtavis merged commit 7da83a2 into activist-org:main Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants