Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added orgs to populate db management command, improved org factory #947

Merged
merged 13 commits into from
Sep 7, 2024

Conversation

to-sta
Copy link
Collaborator

@to-sta to-sta commented Aug 11, 2024

Contributor checklist


Description

I have added the organizations to the populate db command.

WIP:

  • org_text needs to be added to the OrganizationFactory
  • Events should be added
  • Group should be added

Related issue

Copy link
Contributor

github-actions bot commented Aug 11, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit bfe6414
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66dc9c0714dbfc0009781132

@andrewtavis andrewtavis self-requested a review August 11, 2024 14:16
@to-sta
Copy link
Collaborator Author

to-sta commented Aug 12, 2024

I removed the StatusType query within the OrganizationFactory and switched to the factory_boy implementation. With that, we are removing the need of db access for fixtures.

@andrewtavis
Copy link
Member

I've reduced the number of entities/users/events created to 10 as the frontend build speed is faster, and everything's running in parallel now, so the frontend was actually loading faster than the backend with 100 (and even 50).

@andrewtavis
Copy link
Member

This still needs work to get the tests running, and the organization text table isn't returning a description – navigating to /organizations doesn't work as descriptions aren't coming through.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @to-sta, @momanyisamuel and @wkyoshida!

@andrewtavis andrewtavis merged commit e1954ef into activist-org:main Sep 7, 2024
6 checks passed
@andrewtavis andrewtavis mentioned this pull request Sep 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants