Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addition of signal social media #935

Closed

Conversation

UnknownSean8
Copy link
Contributor

Contributor checklist


Description

Added Signal social to the modal share page. Thanks!

Related issue

Copy link
Contributor

github-actions bot commented Jul 27, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 6771199
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66d1fc1acf00090008c3c606
😎 Deploy Preview https://deploy-preview-935--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis andrewtavis self-requested a review July 27, 2024 13:52
@andrewtavis
Copy link
Member

As discussed in the sync, let's look into how we would automatically launch Signal on a person's device and include a default message for sharing :)

@UnknownSean8
Copy link
Contributor Author

Hi, so far regarding the URL link for sharing to Signal, there is no feature to support sending a pre-defined message yet. However, it is possible to have a share-to-signal link. Thanks!

Ref:
signalapp/Signal-iOS#706

@andrewtavis
Copy link
Member

Hey @UnknownSean8 👋 As discussed, would be great if we could still get Signal opened at least, and then we can figure this out later when that issue for Signal is closed 😊

@andrewtavis
Copy link
Member

Comment from the dev sync: Copy the URL to clipboard and open the app :)

@UnknownSean8
Copy link
Contributor Author

Hi @andrewtavis, the feature is working correctly for now. But there are still some settings/preferences that can be improved. Could you take a look and let me know your thoughts?

I think that the copyToClipboard function can be separated from the redirection so we can time the waiting time. But maybe the functions shouldn't exist in the file itself?

Other than that, since the link is using the same contentCopied variable, the copy URL button will also change when the Signal link is clicked. Do you want this behaviour or want it to be separated?

Thanks!

@andrewtavis
Copy link
Member

Hey @UnknownSean8 👋 So all's working well, but I do agree that we want to split the functionality of copying the link and the opening Signal. The copy link shouldn't change in this case, but the Signal option should change to a checkmark and the same green and URL copied should be the text displayed to the user until Signal opens. Can you make those quick changes and then I'll merge it in? :)

@andrewtavis
Copy link
Member

Also, don't worry about how some of the texts are a bit weird at the moment! This is coming from needing to combine a bunch of strings for the rework I talked to you about. It'll get figured out once all the PRs are in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants