Updated Agent Script to Prevent Insecure ACLs #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the .zip file was being copied over to the C:\Program Files directory it was carrying a ACL rule allowing modify access to the folder for the NT AUTHORITY\Authenticated Users group. By doing it this way the only ACLs placed on the C:\Program Files\Sysmon directory will be the ones inherited by C:\Program Files.
When the .zip file was being copied over to the C:\Program Files directory it was carrying a ACL rule allowing modify access to the folder for the NT AUTHORITY\Authenticated Users group. By doing it this way the only ACLs placed on the C:\Program Files\winlogbeat* directory will be the ones inherited by C:\Program Files.
Author
|
The more I look at this the less I think its caused by the .zip file but rather the directory the file is extracted in. Still an issue though. |
william-stearns
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method of installing Sysmon and WinlogBeat are opening up security holes due to an insecure ACL that is carried over when the .zip files are extracted. Specific concerns lay around the WinlogBeat folder permissions as any low priv user on the system is able to replace the service binary which the service will attempt to execute as SYSTEM allowing privilege escalation.
A potential attacker could also just disable the service causing reduced visibility to the host.
Sysmon is less of a concern as when it installs it copies the binaries to C:\Windows\System32 but should still be secured.
It looks like attempts to prevent this were in place in lines 177-180 but as you can see from the screenshot this was not working.