Add purchase form and check purchase response #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galulex
requested changes
Sep 15, 2021
galulex
reviewed
Sep 16, 2021
|
|
||
| ```erbruby | ||
| # checkout.html.erb | ||
| <%= Wayforpay::Helpers.purchase_form( |
There was a problem hiding this comment.
Will it work as regular rails helper (form_for, link_to)?
There was a problem hiding this comment.
nope. I can remove self. part from the method definition and in this case you can just include the module into your controller but in case if somebody is going to use the gem outside rails then it can be not so clear.
I prefer the current implementation because it's straight, explicit, and simple.
There was a problem hiding this comment.
@galulex should I do any changes?
There was a problem hiding this comment.
@galulex any updates? Do you want me to change my code somehow?
|
@bguban Sorry I am AFK. Merging now and will push to rubygems next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7