Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exec to not leak INPUT env variables to child processes #790

Closed
wants to merge 2 commits into from

Conversation

luketomlinson
Copy link
Contributor

Resolves #309

By default, the child_process module in Node will use process.env if no environment is explicitly passed.

For security purposes, we are filtering out the INPUT_* environment variables to prevent these from being passed to subprocesses by default. We do this by first filtering process.env and explicitly passing it to the spawn method.

@luketomlinson luketomlinson requested a review from a team as a code owner May 5, 2021 20:59
@luketomlinson
Copy link
Contributor Author

Closing, since we have close #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exec.exec leaks action input parameters to subprocess
1 participant