Set main as the default branch #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
reviewed
Jul 20, 2020
docs/action-types.md
Outdated
| @@ -32,14 +32,14 @@ jobs: | |||
| os: [ubuntu-16.04, windows-2019] | |||
| runs-on: ${{matrix.os}} | |||
| actions: | |||
| - uses: actions/setup-node@master | |||
| - uses: actions/setup-node@main | |||
There was a problem hiding this comment.
would be better to pin to v1 or v2
ericsciple
reviewed
Jul 20, 2020
| @@ -551,7 +551,7 @@ export async function getManifestFromRepo( | |||
| owner: string, | |||
| repo: string, | |||
| auth?: string, | |||
| branch = 'master' | |||
| branch = 'main' | |||
There was a problem hiding this comment.
check w/ @bryanmacfarlane
There was a problem hiding this comment.
Going to pull this change out and address it in another issue. We should probably default to the default branch of a repo, or force a user to specify, but I don't want to make breaking changes here right now.
#529
ericsciple
approved these changes
Jul 20, 2020
smorimoto
pushed a commit
to smorimoto/toolkit
that referenced
this pull request
Jul 29, 2020
* set main as the default branch * revert change to tool-cache default branch * use versions where applicable
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
* set main as the default branch * revert change to tool-cache default branch * use versions where applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #514