-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add arch to cache key #896
Conversation
@actions/setup-actions-team Can anyone review this? |
@actions/setup-actions-team I'm wondering if anyone is still maintaining this project, between the fact that GitHub has started to offer the Ubuntu arm64 runner, this problem is getting worse. |
@HarithaVattikuti @priya-kinthali Can you take a look on this? |
Hello @Zxilly, Thank you for this PR, we are looking into it and we will get back to you once we have some feedback on this :) |
Hello @Zxilly, We have reviewed and tested the changes from our end for Including arch in the cache key has made the run successful. However, we are unable to see arch in the cache key with all the changes of this PR. Please find the screenshots for reference. Please have a look at this PR and update to have this to be approved and merged. |
@aparnajyothi-y Apparently the cache in the image is an npm cache created by |
I think |
Hello @Zxilly, Please find attached the setup-python cache key screenshots for reference where the changes of Including arch in the cache key has made the run successful. However, we are unable to see arch in the cache key with all the changes of this PR. |
You use the https://github.com/aparnajyothi-y/setup-python/commits/PR%23896-test/ workflow. The branch you created only contains changes to the |
If you want to test this PR, you should directly use |
Hello @Zxilly, Could you please confirm that the code has passed the checks executed by npm run format-check and npm test? We are currently unable to run / view the checks on this PR and need confirmation to proceed with merging this PR. Thank you. |
I'm curious, why don't you execute the tests yourself? It's unimaginable that such a simple PR took almost two months. |
Description:
GitHub has added the arm64 runner, so arch should be used as part of the cache key. Otherwise, if there are
macos-13
macos-14
running at the same time, the late executor will get the wrong cache.This problem is particularly acute for
pipenv
andpoetry
, for whichaction
also caches the contents ofvenv
. This prevents any libraries containing native binary dependencies from working properly.For real-world error, see https://github.com/Zxilly/go-size-analyzer/actions/runs/9564444574/job/26365211564
Check list: