Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove uv cache from docker image #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daha
Copy link

@daha daha commented Jan 24, 2025

This makes the docker image about 25% smaller (~800MB).

Before the change the image is about 3.08GB, reported by docker images and with the change is is about 2.27GB.

Fixes #157

Copy link

github-actions bot commented Jan 24, 2025

Unit Test Results (build & test)

104 tests  ±0   104 ✅ ±0   14s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 765abba. ± Comparison against base commit 2f78ab1.

♻️ This comment has been updated with latest results.

@hsheth2
Copy link
Contributor

hsheth2 commented Jan 27, 2025

Looks like we've got some issues with our CI that should be fixed by #159. Once that's merged, I'll resync this branch with master and hopefully CI will turn green.

@daha
Copy link
Author

daha commented Jan 28, 2025

It looks like the there are still build issues, build script has problems with the new line between the tags in ${{ steps.docker_meta_slim.outputs.tags }} and the second tag are run as a script...

@daha daha force-pushed the remove-uv-cache-from-docker-image branch from 067328d to e541f71 Compare January 30, 2025 15:28
This makes the docker image about 25% smaller (~800MB).
@daha daha force-pushed the remove-uv-cache-from-docker-image branch from e541f71 to 765abba Compare January 31, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image is bigger than it needs to be
2 participants