Skip to content

Commit

Permalink
fix(ci): fix docker image save/load (#159)
Browse files Browse the repository at this point in the history
* fix(ci): fix docker image save/load

I think the `>` character might have issues with yaml.

* ensure it runs on all code with latest
  • Loading branch information
hsheth2 authored Jan 28, 2025
1 parent ec6e41f commit 311d1c0
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/datahub-actions-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:
- main
paths:
- "docker/**"
- "datahub-actions/**"
- ".github/workflows/datahub-actions-docker.yml"
- "!build/**"
- "!**.md"
Expand Down Expand Up @@ -148,7 +149,7 @@ jobs:
"APP_ENV=prod-slim"
- name: Save Docker image
if: needs.setup.outputs.publish != 'true'
run: docker save ${{ steps.docker_meta_slim.outputs.tags }} > image.tar
run: docker image save -o image.tar ${{ steps.docker_meta_slim.outputs.tags }}
- name: Upload artifact
if: needs.setup.outputs.publish != 'true'
uses: actions/upload-artifact@v3
Expand Down Expand Up @@ -205,7 +206,7 @@ jobs:
name: docker-image
- name: Load Docker image (if not publishing)
if: needs.setup.outputs.publish != 'true'
run: docker load < image.tar
run: docker image load -i image.tar
- name: Pull Docker image (if publishing)
if: needs.setup.outputs.publish == 'true'
run: docker pull acryldata/datahub-actions-slim:${{ needs.setup.outputs.unique_tag }}
Expand Down Expand Up @@ -265,8 +266,6 @@ jobs:
DATAHUB_TELEMETRY_ENABLED: false
DATAHUB_ACTIONS_IMAGE: acryldata/datahub-actions-slim
DATAHUB_ACTIONS_VERSION: ${{ needs.setup.outputs.unique_tag }}
ACTIONS_EXTRA_PACKAGES: "acryl-datahub-actions[executor]==0.0.13 acryl-datahub-actions==0.0.13 acryl-datahub==0.10.5"
ACTIONS_CONFIG: "https://raw.githubusercontent.com/acryldata/datahub-actions/main/docker/config/executor.yaml"
run: |
./smoke-test/run-quickstart.sh
- name: Disk Check
Expand Down

0 comments on commit 311d1c0

Please sign in to comment.