Add option to set custom user-agent for token introspector #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semerokozlyat
approved these changes
Feb 21, 2025
vasayxtx
reviewed
Feb 21, 2025
| @@ -154,6 +160,13 @@ func WithJWTParserScopeFilter(scopeFilter jwt.ScopeFilter) JWTParserOption { | |||
| } | |||
| } | |||
|
|
|||
| // WithHTTPUserAgent sets the User-Agent header for HTTP requests to JWKS endpoint. | |||
| func WithHTTPUserAgent(userAgent string) JWTParserOption { | |||
There was a problem hiding this comment.
Could you please rename WithHTTPUserAgent to WithJWTParserHTTPUserAgent for consistency with other JWTParser's options?
vasayxtx
reviewed
Feb 21, 2025
| @@ -173,6 +186,10 @@ func NewTokenIntrospector( | |||
| opt(&options) | |||
| } | |||
|
|
|||
| if options.userAgent == "" { | |||
There was a problem hiding this comment.
It might be better to use a specified user agent as a prefix, similar to how github.com/grpc/grpc-go does. Currently, the user agent for gRPC requests is "go-authkit/v0.16.0 grpc-go/1.64.1".
With this approach, the final user agent would be:
- For gRPC: "<user_agent> go-authkit/v0.16.0 grpc-go/1.64.1"
- For HTTP: "<user_agent> go-authkit/v0.16.0"
@StiegOlSauer, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.