-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/planner #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ANaq21
wants to merge
26
commits into
develop
Choose a base branch
from
feat/planner
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/planner #87
+2,801
−300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WOW! I'm really impressed with the evaluator and the degree planning page. Kudos to you both @ANaq21 and @sudocanttype! Y'all really pulled together and this sets the baseline for how the degree planner works |
joalen
approved these changes
Dec 19, 2025
This was
linked to
issues
Jan 2, 2026
Open
- Fixed issue with outside click for onboarding event - // TODO: add conditional logging for just debug envs only
- for debugging purposes, this is great, but I think it adds too much visual strain for the user. We can keep it simple like this to show that a file uploaded and parsed.
- got planner page to respect the Figma designs, which looks amazing! - removed hardcoded endpoint - lock global scroll for page and respect dark navbar for onboarding and program spec process - // TODO: Fix a few dropdowns and get their interactions working
- the dropdowns weren't interactive; therefore, fixed by adding in the propagation functionalities - added z-index + padding to help the highlighting feel not less awkward - // TODO: add implementation from either CRUD or some other place to be able to fetch available programs for "graduate" and "undergraduate" when populating dropdowns in ProgramValidationB
- container needs to naturally scroll; therefore, added that with the option of hiding the scrollbar - added the disclaimer text as done in the Figma
- for the dropdowns, it was set to use mock dropdown data, but now that's changed by fetching ONCE from CRUD from a degree catalog master dump - remove option made so that users can remove semesters (and even years as needed...only applies for a year that contains a single semester) - the loading page now contains a SAGE spinning icon with the green loading to match with our theme
- needed to make conditional rendering of the small-text to allow switching between "uploading" transcript vs. "manual" editing of programs - // TODO: now, the next thing is adding that disclaimer text for the sidebar
- added disclaimer text for planner page as seen in the Figma - also added the vertical collapse
- added the test and transfer credits containers to show that the transcript parsed out even those sections too and allow users to really confirm what all things they have - additionally...removed the scrollbar and instead replaced with a bouncy arrow to show scrolling further as needed
- got some feedback and the transcript upload section was unnecessarily complicated - therefore, when upload happens, we immediately jump to the next screen unless an error comes, which prompts the user and prevents advancement - back button is of course added, but there in case users wanted to adjust settings - removed some log statements to prevent console flooding - in addition, rather than "active" and "in-active," we delineate between "in progress", "completed", "withdrawn" - these options are good as it gives more info to the user and allows them to see at hand what they're dealing with in the planner program spec pipeline
- ok, so I felt that the arrow "bouncy" effect wasn't that great and to account for average person, the scroll bar is back but in theme with the actual SAGE branding + a bit further from the container to not make it as awkward. - // TODO: implement for FIrefox and other browsers using this
* Prevent dedupe of already added courses onto a planner - added logic to prevent adding an already added course to a term or to another term with an error message - just uncovered a bug where if you add all three semesters, remove just the one semester...can be middle or first, and then add a semester, it somehow jumps to the next semester?? - this will be filed as another issue for me to keep track of, but a really good catch * Removal logic of courses added removal logic for courses to prevent courses from getting "stuck" onto a semester
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planner UI mostly fleshed out and integrated. Few feature implementation/bugs remain