-
Notifications
You must be signed in to change notification settings - Fork 8
Update links to be acm.gg instead of go.acm #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request updates URL links across the application from the legacy domain Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/app/(open-house)/data/orgs_config.json (2)
130-130: Consider using HTTPS instead of HTTP.This ICPC Discord link uses
http://instead ofhttps://. For security and consistency, allacm.gglinks should use HTTPS.Apply this change:
- "link": "http://acm.gg/icpc_discord" + "link": "https://acm.gg/icpc_discord"
147-147: Consider using HTTPS instead of HTTP.This SIGMusic Discord link uses
http://instead ofhttps://. For security and consistency, allacm.gglinks should use HTTPS.Apply this change:
- "link": "http://acm.gg/sigmusic_discord" + "link": "https://acm.gg/sigmusic_discord"src/utils/organizations.ts (2)
102-102: Consider using HTTPS instead of HTTP.This ICPC Discord link uses
http://instead ofhttps://. For security and consistency, allacm.gglinks should use HTTPS (note this same link appears inorgs_config.jsonat line 130 with the same issue).Apply this change:
- link: 'http://acm.gg/icpc_discord', + link: 'https://acm.gg/icpc_discord',
151-151: Consider using HTTPS instead of HTTP.This SIGMusic Discord link uses
http://instead ofhttps://. For security and consistency, allacm.gglinks should use HTTPS (note this same link appears inorgs_config.jsonat line 147 with the same issue).Apply this change:
- link: 'http://acm.gg/sigmusic_discord', + link: 'https://acm.gg/sigmusic_discord',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (7)
src/app/(membership)/membership/page.tsx(1 hunks)src/app/(membership)/paid/page.tsx(1 hunks)src/app/(open-house)/data/orgs_config.json(21 hunks)src/app/(resources)/resources/page.tsx(1 hunks)src/components/Footer/index.tsx(1 hunks)src/components/Hero/index.tsx(3 hunks)src/utils/organizations.ts(6 hunks)
🔇 Additional comments (12)
src/app/(open-house)/data/orgs_config.json (1)
8-520: JSON reformatting improves readability.The reformatting of link arrays from single-line to multi-line objects improves code readability without changing the semantic content.
src/components/Hero/index.tsx (3)
134-134: Link migration looks good.The Discord link has been correctly updated to the new
acm.ggdomain using HTTPS.
227-227: Formatting change only.This is just an indentation adjustment with no functional impact.
116-116: Link migration verified successfully.The donation link redirect chain resolves correctly: the URL follows a 301→302→200 redirect sequence and successfully reaches a valid endpoint, confirming the migration to
acm.gg/donateis working as expected.src/utils/organizations.ts (4)
42-42: Link migration looks good.The SIGAIDA Discord link has been correctly updated to the new
acm.ggdomain using HTTPS.
199-199: Link migration looks good.The SIGecom Discord link has been correctly updated to the new
acm.ggdomain using HTTPS.
210-210: Link migration looks good.The SIGPLAN Discord link has been correctly updated to the new
acm.ggdomain using HTTPS.
285-285: Link migration looks good.The ACM Discord link has been correctly updated to the new
acm.ggdomain using HTTPS.src/components/Footer/index.tsx (1)
27-27: Link migration verified and working correctly.The shortened URL
https://acm.gg/discordproperly redirects through a chain of redirects (301, 302, 301) and successfully resolves to a 200 status code, confirming the link is functional.src/app/(membership)/membership/page.tsx (1)
159-159: Link migration verified successfully.The shortened URL
https://acm.gg/paid-member-guideis correctly configured and reaches a valid destination (200 OK response after redirect chain). The HTTPS link update is functional.src/app/(membership)/paid/page.tsx (1)
31-31: Link migration verified and working correctly.The shortened URL
https://acm.gg/swipeaccessresolves successfully with a final HTTP 200 status after following its redirect chain. The link is functional and properly migrated to the HTTPS acm.gg domain.src/app/(resources)/resources/page.tsx (1)
150-150: Link migration verified successfully.The feedback link has been correctly updated to the new
acm.ggdomain using HTTPS. Verification confirms the shortened URL redirects properly through the chain (301 → 302 → 200) to a valid destination.
Summary by CodeRabbit
Bug Fixes
Chores