Skip to content

Conversation

@devksingh4
Copy link
Member

@devksingh4 devksingh4 commented Oct 31, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Updated various resource links across the site to use the new acm.gg domain, replacing legacy redirect URLs.
  • Chores

    • Reformatted organization links data structure for improved maintainability.

@devksingh4 devksingh4 requested review from a team as code owners October 31, 2025 21:13
@coderabbitai
Copy link

coderabbitai bot commented Oct 31, 2025

Walkthrough

The pull request updates URL links across the application from the legacy domain https://go.acm.illinois.edu/ to the new shortened domain https://acm.gg/. Additionally, a JSON configuration file is reformatted for improved readability without semantic changes.

Changes

Cohort / File(s) Summary
URL domain migration
src/app/(membership)/membership/page.tsx, src/app/(membership)/paid/page.tsx, src/app/(resources)/resources/page.tsx
Updated anchor link hrefs from https://go.acm.illinois.edu/ to https://acm.gg/ for paid member guide, swipe access, and feedback resources.
Component URL updates
src/components/Footer/index.tsx, src/components/Hero/index.tsx
Replaced Discord and donation link URLs in footer and hero navigation components from legacy domain to acm.gg domain.
Organization data link migration
src/utils/organizations.ts
Updated Discord and website links in OrganizationDataMapping for AIDA, ICPC, SIGMusic, ecom, SIGPLAN, and ACM entries from go.acm.illinois.edu to acm.gg.
JSON formatting
src/app/(open-house)/data/orgs_config.json
Reformatted all "links" entries from single-line arrays to multi-line arrays with object structure; semantic content and values unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

  • Changes are homogeneous (consistent URL domain replacement pattern across multiple files)
  • No logic modifications or structural changes to exported entities
  • Primary verification needed: ensure all migrated links point to active and correct resources on the new domain
  • JSON reformatting is a straightforward structural reorganization with no data value changes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Update links to be acm.gg instead of go.acm" clearly and directly describes the primary change across the entire changeset. The raw summary shows that the main objective of this PR is to systematically update URLs from the legacy go.acm.illinois.edu domain to the new acm.gg domain, affecting multiple files including membership pages, footer components, hero section, resources page, and organization configurations. The title is concise, specific, and avoids vague language or unnecessary noise. A teammate scanning the commit history would immediately understand that this PR is about a domain migration for links.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dsingh14/update-links

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Deploying with Cloudflare Pages

Name Result
Last commit: 0b07fe2
Preview URL: https://e6e0e5ca.acmuiuc.pages.dev
Branch Preview URL: https://dsingh14-update-links.acmuiuc.pages.dev

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
src/app/(open-house)/data/orgs_config.json (2)

130-130: Consider using HTTPS instead of HTTP.

This ICPC Discord link uses http:// instead of https://. For security and consistency, all acm.gg links should use HTTPS.

Apply this change:

-        "link": "http://acm.gg/icpc_discord"
+        "link": "https://acm.gg/icpc_discord"

147-147: Consider using HTTPS instead of HTTP.

This SIGMusic Discord link uses http:// instead of https://. For security and consistency, all acm.gg links should use HTTPS.

Apply this change:

-        "link": "http://acm.gg/sigmusic_discord"
+        "link": "https://acm.gg/sigmusic_discord"
src/utils/organizations.ts (2)

102-102: Consider using HTTPS instead of HTTP.

This ICPC Discord link uses http:// instead of https://. For security and consistency, all acm.gg links should use HTTPS (note this same link appears in orgs_config.json at line 130 with the same issue).

Apply this change:

-        link: 'http://acm.gg/icpc_discord',
+        link: 'https://acm.gg/icpc_discord',

151-151: Consider using HTTPS instead of HTTP.

This SIGMusic Discord link uses http:// instead of https://. For security and consistency, all acm.gg links should use HTTPS (note this same link appears in orgs_config.json at line 147 with the same issue).

Apply this change:

-        link: 'http://acm.gg/sigmusic_discord',
+        link: 'https://acm.gg/sigmusic_discord',
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 940e5b4 and 4fc8f0a.

📒 Files selected for processing (7)
  • src/app/(membership)/membership/page.tsx (1 hunks)
  • src/app/(membership)/paid/page.tsx (1 hunks)
  • src/app/(open-house)/data/orgs_config.json (21 hunks)
  • src/app/(resources)/resources/page.tsx (1 hunks)
  • src/components/Footer/index.tsx (1 hunks)
  • src/components/Hero/index.tsx (3 hunks)
  • src/utils/organizations.ts (6 hunks)
🔇 Additional comments (12)
src/app/(open-house)/data/orgs_config.json (1)

8-520: JSON reformatting improves readability.

The reformatting of link arrays from single-line to multi-line objects improves code readability without changing the semantic content.

src/components/Hero/index.tsx (3)

134-134: Link migration looks good.

The Discord link has been correctly updated to the new acm.gg domain using HTTPS.


227-227: Formatting change only.

This is just an indentation adjustment with no functional impact.


116-116: Link migration verified successfully.

The donation link redirect chain resolves correctly: the URL follows a 301→302→200 redirect sequence and successfully reaches a valid endpoint, confirming the migration to acm.gg/donate is working as expected.

src/utils/organizations.ts (4)

42-42: Link migration looks good.

The SIGAIDA Discord link has been correctly updated to the new acm.gg domain using HTTPS.


199-199: Link migration looks good.

The SIGecom Discord link has been correctly updated to the new acm.gg domain using HTTPS.


210-210: Link migration looks good.

The SIGPLAN Discord link has been correctly updated to the new acm.gg domain using HTTPS.


285-285: Link migration looks good.

The ACM Discord link has been correctly updated to the new acm.gg domain using HTTPS.

src/components/Footer/index.tsx (1)

27-27: Link migration verified and working correctly.

The shortened URL https://acm.gg/discord properly redirects through a chain of redirects (301, 302, 301) and successfully resolves to a 200 status code, confirming the link is functional.

src/app/(membership)/membership/page.tsx (1)

159-159: Link migration verified successfully.

The shortened URL https://acm.gg/paid-member-guide is correctly configured and reaches a valid destination (200 OK response after redirect chain). The HTTPS link update is functional.

src/app/(membership)/paid/page.tsx (1)

31-31: Link migration verified and working correctly.

The shortened URL https://acm.gg/swipeaccess resolves successfully with a final HTTP 200 status after following its redirect chain. The link is functional and properly migrated to the HTTPS acm.gg domain.

src/app/(resources)/resources/page.tsx (1)

150-150: Link migration verified successfully.

The feedback link has been correctly updated to the new acm.gg domain using HTTPS. Verification confirms the shortened URL redirects properly through the chain (301 → 302 → 200) to a valid destination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants